Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2149683002: Check for primaryFont in LayoutTextControl::getAvgCharWidth (Closed)

Created:
4 years, 5 months ago by eae
Modified:
4 years, 5 months ago
Reviewers:
cbiesinger
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check for primaryFont in LayoutTextControl::getAvgCharWidth Change LayoutTextControl::getAvgCharWidth to check if primaryFont is set before attempting to access it falling back on measuring the width of 0. BUG=627818 R=cbiesinger@chromium.org Committed: https://crrev.com/c37d7c08fe436fe0f53245eff661ada8c420a849 Cr-Commit-Position: refs/heads/master@{#405355}

Patch Set 1 #

Patch Set 2 : Rebase w/HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/core/layout/LayoutTextControl.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
eae
4 years, 5 months ago (2016-07-13 17:17:48 UTC) #1
cbiesinger
lgtm. This did not affect any tests?
4 years, 5 months ago (2016-07-13 18:12:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149683002/20001
4 years, 5 months ago (2016-07-13 21:00:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/244597)
4 years, 5 months ago (2016-07-13 22:44:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149683002/20001
4 years, 5 months ago (2016-07-13 23:19:35 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 23:59:44 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 00:01:06 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c37d7c08fe436fe0f53245eff661ada8c420a849
Cr-Commit-Position: refs/heads/master@{#405355}

Powered by Google App Engine
This is Rietveld 408576698