Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2711)

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 2149663004: Mark WebViewTest.InterstitialTeardownOnBrowserShutdown flaky on all platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: bug number Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/guest_view/web_view_browsertest.cc
diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc
index a414b173709fe761877f3ab2d079c46e5197d056..a5876329a3b59e90f194fa896e8de44595c61e78 100644
--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc
+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc
@@ -1541,16 +1541,9 @@ IN_PROC_BROWSER_TEST_P(WebViewTest, InterstitialTeardown) {
// This test makes sure the browser process does not crash if browser is shut
// down while an interstitial page is being shown in guest.
-// Flaky on Windows. http://crbug.com/619508.
-#if defined(OS_WIN)
-#define MAYBE_InterstitialTeardownOnBrowserShutdown \
- DISABLED_InterstitialTeardownOnBrowserShutdown
-#else
-#define MAYBE_InterstitialTeardownOnBrowserShutdown \
- InterstitialTeardownOnBrowserShutdown
-#endif
+// Flaky. http://crbug.com/627962.
IN_PROC_BROWSER_TEST_P(WebViewTest,
- MAYBE_InterstitialTeardownOnBrowserShutdown) {
+ DISABLED_InterstitialTeardownOnBrowserShutdown) {
InterstitialTeardownTestHelper();
// Now close the app while interstitial page being shown in guest.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698