Reorder fields of AstNode subclasses for better packing

Reorder fields of AstNode subclasses for better packing

BUG=

Committed: https://crrev.com/3cd82879e664a92d848bf141218720ee12d6be57
Cr-Commit-Position: refs/heads/master@{#37834}

[Toon Verwaest, 2016-07-13 18:40:06]

Patchset #1 (id:1) has been deleted

[Toon Verwaest, 2016-07-15 07:49:51]

verwaest@chromium.org changed reviewers:
+ ishell@chromium.org

[Toon Verwaest, 2016-07-15 07:49:52]

ptal

[Igor Sheludko, 2016-07-15 08:54:50]

lgtm

[Toon Verwaest, 2016-07-15 09:25:38]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-07-15 09:25:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 09:29:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 09:29:51]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/19550)

[Toon Verwaest, 2016-07-15 09:31:59]

verwaest@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Toon Verwaest, 2016-07-15 09:32:00]

mstarzinger: ptal as owner

[Michael Starzinger, 2016-07-18 08:20:53]

LGTM.

https://codereview.chromium.org/2149663003/diff/80001/src/ast/ast.h
File src/ast/ast.h (right):

https://codereview.chromium.org/2149663003/diff/80001/src/ast/ast.h#newcode377
src/ast/ast.h:377: uint16_t bit_field_ = 0;
nit: Why use implicit initialization here and explicit everywhere else? Can we
make this one explicit as well (just for symmetry and readability)?

[Toon Verwaest, 2016-07-18 09:30:42]

Addressed, thanks!

[Toon Verwaest, 2016-07-18 09:32:07]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-07-18 09:32:07]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2149663003/#ps100001
(title: "Addressed comment")

[commit-bot: I haz the power, 2016-07-18 09:32:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 09:33:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 09:33:44]

Try jobs failed on following builders:
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/19648)

[Toon Verwaest, 2016-07-18 10:53:57]

Patchset #5 (id:100001) has been deleted

[Toon Verwaest, 2016-07-18 10:55:12]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-07-18 10:55:12]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2149663003/#ps120001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-07-18 10:55:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 12:29:49]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-07-18 12:33:06]

Description was changed from

==========
Reorder fields of AstNode subclasses for better packing

BUG=
==========

to

==========
Reorder fields of AstNode subclasses for better packing

BUG=

Committed: https://crrev.com/3cd82879e664a92d848bf141218720ee12d6be57
Cr-Commit-Position: refs/heads/master@{#37834}
==========

[commit-bot: I haz the power, 2016-07-18 12:33:08]

Patchset 5 (id:??) landed as
https://crrev.com/3cd82879e664a92d848bf141218720ee12d6be57
Cr-Commit-Position: refs/heads/master@{#37834}