Ensured that any failure to create a WebGL context dispatches a webglcontextcreationerror

Ensured that any failure to create a WebGL context dispatches a webglcontextcreationerror

BUG=352282
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170213

[bajones, 2014-03-27 17:51:20]

PTAL. There were some early termination cases during WebGL context creation that
didn't fire the expected events.

[Ken Russell (switch to Gerrit), 2014-03-27 18:57:41]

https://codereview.chromium.org/214963003/diff/1/Source/core/html/HTMLCanvasE...
File Source/core/html/HTMLCanvasElement.cpp (right):

https://codereview.chromium.org/214963003/diff/1/Source/core/html/HTMLCanvasE...
Source/core/html/HTMLCanvasElement.cpp:182: if (type == "webkit-3d")
Support for this legacy context name should be removed. Could you please file a
bug about doing so?

https://codereview.chromium.org/214963003/diff/1/Source/core/html/HTMLCanvasE...
Source/core/html/HTMLCanvasElement.cpp:193: if (settings &&
settings->webGLEnabled()) {
This test is redundant -- it's already done in WebGLRenderingContext::create().
Let's not add this check here.

https://codereview.chromium.org/214963003/diff/1/Source/core/html/HTMLCanvasE...
Source/core/html/HTMLCanvasElement.cpp:208:
dispatchEvent(WebGLContextEvent::create(EventTypeNames::webglcontextcreationerror,
false, true, "Web page was not allowed to create a WebGL context."));
This error should be handled inside WebGLRenderingContext::create().

[bajones, 2014-03-27 20:35:00]

On 2014/03/27 18:57:41, Ken Russell wrote:
>
https://codereview.chromium.org/214963003/diff/1/Source/core/html/HTMLCanvasE...
> Source/core/html/HTMLCanvasElement.cpp:182: if (type == "webkit-3d")
> Support for this legacy context name should be removed. Could you please file
a
> bug about doing so?

crbug.com/357296

>
https://codereview.chromium.org/214963003/diff/1/Source/core/html/HTMLCanvasE...
> Source/core/html/HTMLCanvasElement.cpp:193: if (settings &&
> settings->webGLEnabled()) {
> This test is redundant -- it's already done in
WebGLRenderingContext::create().
> Let's not add this check here.

Done.

>
https://codereview.chromium.org/214963003/diff/1/Source/core/html/HTMLCanvasE...
> Source/core/html/HTMLCanvasElement.cpp:208:
>
dispatchEvent(WebGLContextEvent::create(EventTypeNames::webglcontextcreationerror,
> false, true, "Web page was not allowed to create a WebGL context."));
> This error should be handled inside WebGLRenderingContext::create().

Done.

[Ken Russell (switch to Gerrit), 2014-03-27 20:40:34]

Thanks. LGTM

[bajones, 2014-03-27 20:50:37]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2014-03-27 20:50:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bajones@chromium.org/214963003/20001

[commit-bot: I haz the power, 2014-03-27 22:32:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 22:32:59]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[bajones, 2014-03-27 22:40:29]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2014-03-27 22:41:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bajones@chromium.org/214963003/20001

[commit-bot: I haz the power, 2014-03-27 22:45:00]

Change committed as 170213