Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 214963002: Add error message for domain mismatch on re-enrollment. (Closed)

Created:
6 years, 9 months ago by Mattias Nissler (ping if slow)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, jar (doing other things), asvitkine+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, Bin
Visibility:
Public.

Description

Add error message for domain mismatch on re-enrollment. This error shows up if the server indicates to the client that enrollment got rejected due to the device belonging do a different domain (as indicated by the client-provided state key). BUG=chromium:357207 TEST=Manual, check that the error message shows up on domain mismatch. R=asvitkine@chromium.org, dpolukhin@chromium.org, joaodasilva@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260102 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260216

Patch Set 1 #

Patch Set 2 : Self-review. #

Total comments: 2

Patch Set 3 : Add string ID to grit_whitelist.txt #

Total comments: 2

Patch Set 4 : Remove stray quote. #

Patch Set 5 : Move message declaration in policy_strings.grdp to work around an Android build issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M build/ios/grit_whitelist.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/chromeos_strings.grdp View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M components/policy/core/browser/cloud/message_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_constants.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/policy/core/common/cloud/device_management_service.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M components/policy/core/common/cloud/enterprise_metrics.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/policy_strings.grdp View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Mattias Nissler (ping if slow)
Please review: joaodasilva@: Main reviewer nkostylev@: chromeos OWNERS asvitkine@: histograms.xml OWNERS
6 years, 9 months ago (2014-03-27 17:10:10 UTC) #1
Mattias Nissler (ping if slow)
Joao, any idea why this fails: http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/136328/steps/compile/logs/stdio ?
6 years, 9 months ago (2014-03-27 17:29:33 UTC) #2
Joao da Silva
On 2014/03/27 17:29:33, Mattias Nissler wrote: > Joao, any idea why this fails: > http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/136328/steps/compile/logs/stdio ...
6 years, 9 months ago (2014-03-27 17:31:47 UTC) #3
Joao da Silva
On 2014/03/27 17:31:47, Joao da Silva wrote: > On 2014/03/27 17:29:33, Mattias Nissler wrote: > ...
6 years, 9 months ago (2014-03-27 17:32:20 UTC) #4
Joao da Silva
Can you post a screenshot on the bug?
6 years, 9 months ago (2014-03-27 17:59:33 UTC) #5
Joao da Silva
lgtm https://codereview.chromium.org/214963002/diff/20001/components/policy/core/common/cloud/device_management_service.cc File components/policy/core/common/cloud/device_management_service.cc (right): https://codereview.chromium.org/214963002/diff/20001/components/policy/core/common/cloud/device_management_service.cc#newcode44 components/policy/core/common/cloud/device_management_service.cc:44: const int kDomainMismatch = 406; Should Bin have ...
6 years, 9 months ago (2014-03-27 18:04:47 UTC) #6
Alexei Svitkine (slow)
histograms lgtm
6 years, 9 months ago (2014-03-27 19:55:16 UTC) #7
Dmitry Polukhin
chromeos LGMT
6 years, 9 months ago (2014-03-27 20:52:01 UTC) #8
Dmitry Polukhin
LGTM
6 years, 9 months ago (2014-03-27 20:52:29 UTC) #9
Mattias Nissler (ping if slow)
https://codereview.chromium.org/214963002/diff/20001/components/policy/core/common/cloud/device_management_service.cc File components/policy/core/common/cloud/device_management_service.cc (right): https://codereview.chromium.org/214963002/diff/20001/components/policy/core/common/cloud/device_management_service.cc#newcode44 components/policy/core/common/cloud/device_management_service.cc:44: const int kDomainMismatch = 406; On 2014/03/27 18:04:47, Joao ...
6 years, 9 months ago (2014-03-27 21:04:19 UTC) #10
Mattias Nissler (ping if slow)
The CQ bit was checked by mnissler@chromium.org
6 years, 9 months ago (2014-03-27 21:14:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/214963002/40001
6 years, 9 months ago (2014-03-27 21:17:27 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 00:58:20 UTC) #13
commit-bot: I haz the power
Retried try job too often on ios_rel_device for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_device&number=127702
6 years, 9 months ago (2014-03-28 00:58:20 UTC) #14
Joao da Silva
https://codereview.chromium.org/214963002/diff/40001/build/ios/grit_whitelist.txt File build/ios/grit_whitelist.txt (right): https://codereview.chromium.org/214963002/diff/40001/build/ios/grit_whitelist.txt#newcode703 build/ios/grit_whitelist.txt:703: IDS_POLICY_DM_STATUS_SERVICE_DOMAIN_MISMATCH" Remove that extra " :-)
6 years, 9 months ago (2014-03-28 01:02:28 UTC) #15
Mattias Nissler (ping if slow)
https://codereview.chromium.org/214963002/diff/40001/build/ios/grit_whitelist.txt File build/ios/grit_whitelist.txt (right): https://codereview.chromium.org/214963002/diff/40001/build/ios/grit_whitelist.txt#newcode703 build/ios/grit_whitelist.txt:703: IDS_POLICY_DM_STATUS_SERVICE_DOMAIN_MISMATCH" On 2014/03/28 01:02:29, Joao da Silva wrote: > ...
6 years, 9 months ago (2014-03-28 09:10:59 UTC) #16
Mattias Nissler (ping if slow)
The CQ bit was checked by mnissler@chromium.org
6 years, 9 months ago (2014-03-28 09:11:22 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/214963002/60001
6 years, 9 months ago (2014-03-28 09:12:14 UTC) #18
Mattias Nissler (ping if slow)
Committed patchset #4 manually as r260102 (presubmit successful).
6 years, 9 months ago (2014-03-28 11:14:00 UTC) #19
Mattias Nissler (ping if slow)
The android_dbg_triggered_tests is green with the string resource declared at the end of the file, ...
6 years, 9 months ago (2014-03-28 18:23:09 UTC) #20
Mattias Nissler (ping if slow)
6 years, 9 months ago (2014-03-28 18:44:25 UTC) #21
Message was sent while issue was closed. 
Committed patchset #5 manually as r260216 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698