Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2149603003:
Use IsSigninProfile instead. (Closed)
DescriptionUse IsSigninProfile instead.
This is just code cleanup, IsSigninProfile does the same thing. This affects chromeos only.
BUG=
TBR=skuhne@chromium.org
Committed: https://crrev.com/2d17c6d01996c6c504b3415deabe7e3e0bcdbc2e
Cr-Commit-Position: refs/heads/master@{#405227}
Patch Set 1 #
Messages
Total messages: 26 (14 generated)
The CQ bit was checked by achuith@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
achuith@chromium.org changed reviewers: + mmenke@chromium.org
Matt, please take a look.
On 2016/07/13 16:46:30, achuithb wrote: > Matt, please take a look. Sorry, I don't know this code - I only own the network-related components of profiles/. Not even familiar enough with the rest to suggest a good reviewer for this.
On 2016/07/13 16:48:49, mmenke wrote: > On 2016/07/13 16:46:30, achuithb wrote: > > Matt, please take a look. > > Sorry, I don't know this code - I only own the network-related components of > profiles/. Not even familiar enough with the rest to suggest a good reviewer > for this. You may want to beef up the description a bit - it's not clear that this is a ChromeOS-only change, or what you're using the SignIn profile instead of. Also not clear if this is fixing a bug, just a cleanup, or what.
Description was changed from ========== Use IsSigninProfile instead. BUG= ========== to ========== Use IsSigninProfile instead. This is just code cleanup, IsSigninProfile does the same thing. BUG= ==========
Description was changed from ========== Use IsSigninProfile instead. This is just code cleanup, IsSigninProfile does the same thing. BUG= ========== to ========== Use IsSigninProfile instead. This is just code cleanup, IsSigninProfile does the same thing. This affects chromeos only. BUG= ==========
On 2016/07/13 16:50:55, mmenke wrote: > On 2016/07/13 16:48:49, mmenke wrote: > > On 2016/07/13 16:46:30, achuithb wrote: > > > Matt, please take a look. > > > > Sorry, I don't know this code - I only own the network-related components of > > profiles/. Not even familiar enough with the rest to suggest a good reviewer > > for this. > > You may want to beef up the description a bit - it's not clear that this is a > ChromeOS-only change, or what you're using the SignIn profile instead of. Also > not clear if this is fixing a bug, just a cleanup, or what. I've updated the description. skuhne@ would be the right reviewer, but he's OOO. Don't worry about it
achuith@chromium.org changed reviewers: + xiyuan@chromium.org
Xiyuan, could you please take a look?
mmenke@chromium.org changed reviewers: - mmenke@chromium.org
lgtm
On 2016/07/13 17:20:58, xiyuan wrote: > lgtm You probably still need an owner's stamp. :p
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Use IsSigninProfile instead. This is just code cleanup, IsSigninProfile does the same thing. This affects chromeos only. BUG= ========== to ========== Use IsSigninProfile instead. This is just code cleanup, IsSigninProfile does the same thing. This affects chromeos only. BUG= TBR=skuhne@chromium.org ==========
achuith@chromium.org changed reviewers: + skuhne@chromium.org
Trivial issue, going to TBR skuhne@
The CQ bit was checked by achuith@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Use IsSigninProfile instead. This is just code cleanup, IsSigninProfile does the same thing. This affects chromeos only. BUG= TBR=skuhne@chromium.org ========== to ========== Use IsSigninProfile instead. This is just code cleanup, IsSigninProfile does the same thing. This affects chromeos only. BUG= TBR=skuhne@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Use IsSigninProfile instead. This is just code cleanup, IsSigninProfile does the same thing. This affects chromeos only. BUG= TBR=skuhne@chromium.org ========== to ========== Use IsSigninProfile instead. This is just code cleanup, IsSigninProfile does the same thing. This affects chromeos only. BUG= TBR=skuhne@chromium.org Committed: https://crrev.com/2d17c6d01996c6c504b3415deabe7e3e0bcdbc2e Cr-Commit-Position: refs/heads/master@{#405227} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2d17c6d01996c6c504b3415deabe7e3e0bcdbc2e Cr-Commit-Position: refs/heads/master@{#405227} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
