Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: src/compiler/type-hints.cc

Issue 2149583002: [turbofan] Extend undefined-to-number truncation to all oddballs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/type-hints.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/type-hints.cc
diff --git a/src/compiler/type-hints.cc b/src/compiler/type-hints.cc
index e6088328b9856c1373cd521dd021ae00a93c2a10..3176cfc17cf9fc562c93599e4cec370caa42b089 100644
--- a/src/compiler/type-hints.cc
+++ b/src/compiler/type-hints.cc
@@ -16,8 +16,8 @@ std::ostream& operator<<(std::ostream& os, BinaryOperationHints::Hint hint) {
return os << "SignedSmall";
case BinaryOperationHints::kSigned32:
return os << "Signed32";
- case BinaryOperationHints::kNumberOrUndefined:
- return os << "NumberOrUndefined";
+ case BinaryOperationHints::kNumberOrOddball:
+ return os << "NumberOrOddball";
case BinaryOperationHints::kString:
return os << "String";
case BinaryOperationHints::kAny:
@@ -39,8 +39,8 @@ std::ostream& operator<<(std::ostream& os, CompareOperationHints::Hint hint) {
return os << "Boolean";
case CompareOperationHints::kSignedSmall:
return os << "SignedSmall";
- case CompareOperationHints::kNumber:
- return os << "Number";
+ case CompareOperationHints::kNumberOrOddball:
+ return os << "NumberOrOddball";
case CompareOperationHints::kString:
return os << "String";
case CompareOperationHints::kInternalizedString:
@@ -112,10 +112,10 @@ bool BinaryOperationHints::Is(Hint h1, Hint h2) {
case kNone:
return true;
case kSignedSmall:
- return h2 == kSigned32 || h2 == kNumberOrUndefined || h2 == kAny;
+ return h2 == kSigned32 || h2 == kNumberOrOddball || h2 == kAny;
case kSigned32:
- return h2 == kNumberOrUndefined || h2 == kAny;
- case kNumberOrUndefined:
+ return h2 == kNumberOrOddball || h2 == kAny;
+ case kNumberOrOddball:
return h2 == kAny;
case kString:
return h2 == kAny;
« no previous file with comments | « src/compiler/type-hints.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698