Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2149583002: [turbofan] Extend undefined-to-number truncation to all oddballs. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Extend undefined-to-number truncation to all oddballs. Extends the truncation and type checks for NumberOrUndefined in representation selection and truncation analysis to deal with all oddballs not just undefined. Also extend the type hints to always report NumberOrOddball. This is necessary for the bitwise and shift operators where NUMBER feedback actually means NUMBER or ODDBALL. R=jarin@chromium.org Committed: https://crrev.com/04b4df2cadd759245f4df6b77333e934f23dc984 Cr-Commit-Position: refs/heads/master@{#37711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -50 lines) Patch
M src/compiler/js-typed-lowering.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/representation-change.h View 3 chunks +5 lines, -12 lines 0 comments Download
M src/compiler/representation-change.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 8 chunks +9 lines, -11 lines 0 comments Download
M src/compiler/type-hint-analyzer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/type-hints.h View 2 chunks +2 lines, -9 lines 0 comments Download
M src/compiler/type-hints.cc View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-13 12:37:40 UTC) #1
Jarin
lgtm
4 years, 5 months ago (2016-07-13 12:40:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149583002/1
4 years, 5 months ago (2016-07-13 12:50:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 12:59:25 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 12:59:26 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 13:00:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04b4df2cadd759245f4df6b77333e934f23dc984
Cr-Commit-Position: refs/heads/master@{#37711}

Powered by Google App Engine
This is Rietveld 408576698