Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2149533003:
Remove use of unsupported Skia flag (Closed)
|
Created:
4 years, 5 months ago by robertphillips Modified:
4 years, 5 months ago CC:
cc-bugs_chromium.org, chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove use of unsupported Skia flag
The Skia CL (https://codereview.chromium.org/1950523002/ Remove GrLayerHoister) removes the code that used this flag.
Brian: skia
Enne: cc
Committed: https://crrev.com/7b9fe62ae8a9e48f276d5779642114511d4c8235
Cr-Commit-Position: refs/heads/master@{#405480}
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
Description was changed from ========== Remove use of unsupported Skia flag ========== to ========== Remove use of unsupported Skia flag CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Description was changed from ========== Remove use of unsupported Skia flag CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Remove use of unsupported Skia flag The Skia CL (https://codereview.chromium.org/1950523002/ Remove GrLayerHoister) removes the code that used this flag. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Brian: skia Enne: cc ==========
robertphillips@google.com changed reviewers: + bsalomon@google.com, enne@chromium.org
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s): * Specifying master names without "master." prefix is deprecated: tryserver.blink. For more details, see http://crbug.com/617627.
lgtm
lgtm
Your CL relies on deprecated CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
tryserver.blink
For more details, see http://crbug.com/617627.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
tryserver.blink
For more details, see http://crbug.com/617627.
Description was changed from ========== Remove use of unsupported Skia flag The Skia CL (https://codereview.chromium.org/1950523002/ Remove GrLayerHoister) removes the code that used this flag. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Brian: skia Enne: cc ========== to ========== Remove use of unsupported Skia flag The Skia CL (https://codereview.chromium.org/1950523002/ Remove GrLayerHoister) removes the code that used this flag. Brian: skia Enne: cc ==========
Message was sent while issue was closed.
Description was changed from ========== Remove use of unsupported Skia flag The Skia CL (https://codereview.chromium.org/1950523002/ Remove GrLayerHoister) removes the code that used this flag. Brian: skia Enne: cc ========== to ========== Remove use of unsupported Skia flag The Skia CL (https://codereview.chromium.org/1950523002/ Remove GrLayerHoister) removes the code that used this flag. Brian: skia Enne: cc ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove use of unsupported Skia flag The Skia CL (https://codereview.chromium.org/1950523002/ Remove GrLayerHoister) removes the code that used this flag. Brian: skia Enne: cc ========== to ========== Remove use of unsupported Skia flag The Skia CL (https://codereview.chromium.org/1950523002/ Remove GrLayerHoister) removes the code that used this flag. Brian: skia Enne: cc Committed: https://crrev.com/7b9fe62ae8a9e48f276d5779642114511d4c8235 Cr-Commit-Position: refs/heads/master@{#405480} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7b9fe62ae8a9e48f276d5779642114511d4c8235 Cr-Commit-Position: refs/heads/master@{#405480} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
