Enable Scroll Animation for RenderLayerScrollableArea

Source/core/page/PageAnimator.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/page/PageAnimator.h"
 
 #include "core/animation/DocumentAnimations.h"
 #include "core/dom/Document.h"
 #include "core/frame/FrameView.h"
@@ skipping 11 matching lines @@
     , m_servicingAnimations(false)
     , m_updatingLayoutAndStyleForPainting(false)
 {
 }
 
 void PageAnimator::serviceScriptedAnimations(double monotonicAnimationStartTime)
 {
     m_animationFramePending = false;
     TemporaryChange<bool> servicing(m_servicingAnimations, true);
 
+    Vector<RefPtr<Document> > documents;
+
     for (RefPtr<LocalFrame> frame = m_page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
         frame->view()->serviceScrollAnimations();
+
+        if (const FrameView::ScrollableAreaSet* scrollableAreas = frame->view()->scrollableAreas()) {
+            for (FrameView::ScrollableAreaSet::iterator it = scrollableAreas->begin(); it != scrollableAreas->end(); ++it)
+                (*it)->serviceScrollAnimations();
+        }
+
         DocumentAnimations::updateAnimationTimingForAnimationFrame(*frame->document(), monotonicAnimationStartTime);
         SVGDocumentExtensions::serviceOnAnimationFrame(*frame->document(), monotonicAnimationStartTime);
+        documents.append(frame->document());
     }
 
-    Vector<RefPtr<Document> > documents;
-    for (LocalFrame* frame = m_page->mainFrame(); frame; frame = frame->tree().traverseNext())
-        documents.append(frame->document());

[abarth-chromium, 2014/04/14 18:52:25]

Please just move this loop to the top of the function and then iterate the
documents Vector instead of walking the frame tree.  Yes, we'll still have
multiple loops, but that's fine.

[abarth-chromium, 2014/04/14 18:52:57]

By the top of the function, I mean between lines 31 and 32.

-
     for (size_t i = 0; i < documents.size(); ++i)
         documents[i]->serviceScriptedAnimations(monotonicAnimationStartTime);
 
     // Frame callbacks might have started new players or caused existing players to become outdated.
     for (size_t i = 0; i < documents.size(); ++i)
         DocumentAnimations::updateOutdatedAnimationPlayersAfterFrameCallbacks(*documents[i]);
 }
 
 void PageAnimator::scheduleVisualUpdate()
 {
@@ skipping 16 matching lines @@
     // setFrameRect(). This will be a quick operation for most frames, but the
     // NativeWindowWidgets will update a proper clipping region.
     view->setFrameRect(view->frameRect());
 
     // setFrameRect may have the side-effect of causing existing page layout to
     // be invalidated, so layout needs to be called last.
     view->updateLayoutAndStyleForPainting();
 }
 
 }