Enable Scroll Animation for RenderLayerScrollableArea

Source/core/page/PageAnimator.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/page/PageAnimator.h"
 
 #include "core/animation/DocumentAnimations.h"
 #include "core/dom/Document.h"
 #include "core/frame/FrameView.h"
@@ skipping 11 matching lines @@
     , m_servicingAnimations(false)
     , m_updatingLayoutAndStyleForPainting(false)
 {
 }
 
 void PageAnimator::serviceScriptedAnimations(double monotonicAnimationStartTime)
 {
     m_animationFramePending = false;
     TemporaryChange<bool> servicing(m_servicingAnimations, true);
 
+    Vector<RefPtr<Document> > documents;
+    for (RefPtr<LocalFrame> frame = m_page->mainFrame(); frame; frame = frame->tree().traverseNext())
+        documents.append(frame->document());

[weiliangc, 2014/04/14 19:04:32]

Like this?

[abarth-chromium, 2014/04/14 20:15:34]

Yes, thank you.

+
     for (RefPtr<LocalFrame> frame = m_page->mainFrame(); frame; frame = frame->tree().traverseNext()) {

[abarth-chromium, 2014/04/14 20:15:34]

Please iterate the documents collection instead of the Frames.  It's possible
that inside this loop, we'll run JavaScript, which can mutate the frame tree. 
That will break this iteration.

When iterating the documents, you'll need to check whether they're still present
in their frames but null checking document->frame().

[weiliangc, 2014/04/14 20:29:38]

I need to use FrameViews. as long as document->frame() not null, I should be
able to get valid FrameView from document->view(), correct?

Also is the checking also needed for all other three looping though document
under? Or only the some of the loops?

Thanks.

         frame->view()->serviceScrollAnimations();
-        DocumentAnimations::updateAnimationTimingForAnimationFrame(*frame->document(), monotonicAnimationStartTime);
-        SVGDocumentExtensions::serviceOnAnimationFrame(*frame->document(), monotonicAnimationStartTime);
+
+        if (const FrameView::ScrollableAreaSet* scrollableAreas = frame->view()->scrollableAreas()) {
+            for (FrameView::ScrollableAreaSet::iterator it = scrollableAreas->begin(); it != scrollableAreas->end(); ++it)
+                (*it)->serviceScrollAnimations();
+        }
     }
 
-    Vector<RefPtr<Document> > documents;
-    for (LocalFrame* frame = m_page->mainFrame(); frame; frame = frame->tree().traverseNext())
-        documents.append(frame->document());
+    for (size_t i = 0; i < documents.size(); ++i) {
+        DocumentAnimations::updateAnimationTimingForAnimationFrame(*documents[i], monotonicAnimationStartTime);
+        SVGDocumentExtensions::serviceOnAnimationFrame(*documents[i], monotonicAnimationStartTime);
+    }
 
     for (size_t i = 0; i < documents.size(); ++i)
         documents[i]->serviceScriptedAnimations(monotonicAnimationStartTime);
 
     // Frame callbacks might have started new players or caused existing players to become outdated.
     for (size_t i = 0; i < documents.size(); ++i)
         DocumentAnimations::updateOutdatedAnimationPlayersAfterFrameCallbacks(*documents[i]);
 }
 
 void PageAnimator::scheduleVisualUpdate()
@@ skipping 17 matching lines @@
     // setFrameRect(). This will be a quick operation for most frames, but the
     // NativeWindowWidgets will update a proper clipping region.
     view->setFrameRect(view->frameRect());
 
     // setFrameRect may have the side-effect of causing existing page layout to
     // be invalidated, so layout needs to be called last.
     view->updateLayoutAndStyleForPainting();
 }
 
 }