Make invalidateFramebuffer no-op for DEPTH_STENCIL attachment

gpu/command_buffer/service/framebuffer_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/framebuffer_manager.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/logging.h"
@@ skipping 385 matching lines @@
     GLenum attachment) const {
   AttachmentMap::const_iterator it =
       attachments_.find(attachment);
   if (it != attachments_.end()) {
     const Attachment* attachment = it->second.get();
     return !attachment->cleared();
   }
   return false;
 }
 
+bool Framebuffer::HasDepthStencilFormatAttachment(
+    GLenum attachment) const {
+  AttachmentMap::const_iterator it = attachments_.find(attachment);
+  if (it != attachments_.end()) {
+    const Attachment* attachment = it->second.get();
+    GLenum internal_format = attachment->internal_format();
+    return TextureManager::ExtractFormatFromStorageFormat(internal_format) ==
+           GL_DEPTH_STENCIL;

[qiankun, 2016/07/18 04:50:09]

4 space indent.

+  }
+  return false;
+}
+
 bool Framebuffer::HasUnclearedColorAttachments() const {
   for (AttachmentMap::const_iterator it = attachments_.begin();
        it != attachments_.end(); ++it) {
     if (it->first >= GL_COLOR_ATTACHMENT0 &&
         it->first < GL_COLOR_ATTACHMENT0 + manager_->max_draw_buffers_) {
       const Attachment* attachment = it->second.get();
       if (!attachment->cleared())
         return true;
     }
   }
@@ skipping 100 matching lines @@
     if (attachment->IsPartiallyCleared() || attachment->Is3D() ||
         GLES2Util::IsIntegerFormat(attachment->internal_format())) {
       texture_manager->ClearTextureLevel(decoder,
                                          attachment->texture(),
                                          attachment->target(),
                                          attachment->level());
     }
   }
 }
 
+// TODO: when the texture or the renderbuffer in format DEPTH_STENCIL, mark
+// the specific part (depth or stencil) of it as cleared or uncleared instead
+// of the whole one.
 void Framebuffer::MarkAttachmentAsCleared(
       RenderbufferManager* renderbuffer_manager,
       TextureManager* texture_manager,
       GLenum attachment,
       bool cleared) {
   AttachmentMap::iterator it = attachments_.find(attachment);
   if (it != attachments_.end()) {
     Attachment* a = it->second.get();
     if (a->cleared() != cleared) {
       a->SetCleared(renderbuffer_manager,
@@ skipping 181 matching lines @@
   GLenum result = glCheckFramebufferStatusEXT(target);
 
   if (result == GL_FRAMEBUFFER_COMPLETE) {
     manager_->GetFramebufferComboCompleteCache()->SetComplete(signature);
   }
 
   return result;
 }
 
 bool Framebuffer::IsCleared() const {
-  // are all the attachments cleaared?
+  // are all the attachments cleared?
   for (AttachmentMap::const_iterator it = attachments_.begin();
        it != attachments_.end(); ++it) {
     Attachment* attachment = it->second.get();
     if (!attachment->cleared()) {
       return false;
     }
   }
   return true;
 }
 
@@ skipping 196 matching lines @@
 
 bool FramebufferManager::IsComplete(
     Framebuffer* framebuffer) {
   DCHECK(framebuffer);
   return framebuffer->framebuffer_complete_state_count_id() ==
       framebuffer_state_change_count_;
 }
 
 }  // namespace gles2
 }  // namespace gpu