Mod does not rely on a fixed register anymore

src/ia32/lithium-ia32.cc

Index: src/ia32/lithium-ia32.cc
diff --git a/src/ia32/lithium-ia32.cc b/src/ia32/lithium-ia32.cc
index 2fa038baa49736ea188662e1a876d2cc68bb16b3..59c66818de436108a92d19f3e81afdf24babaa5a 100644
--- a/src/ia32/lithium-ia32.cc
+++ b/src/ia32/lithium-ia32.cc
@@ -807,10 +807,11 @@ LInstruction* LChunkBuilder::DoArithmeticD(Token::Value op,
   ASSERT(instr->representation().IsDouble());
   ASSERT(instr->left()->representation().IsDouble());
   ASSERT(instr->right()->representation().IsDouble());
-  ASSERT(op != Token::MOD);
   LOperand* left = UseRegisterAtStart(instr->BetterLeftOperand());
   LOperand* right = UseRegisterAtStart(instr->BetterRightOperand());
   LArithmeticD* result = new(zone()) LArithmeticD(op, left, right);
+  // We call a C function for double modulo. It can't trigger a GC.
+  if (op == Token::MOD) return MarkAsCall(DefineSameAsFirst(result), instr);

[Jakob Kummerow, 2013/08/01 11:42:15]

Why DefineSameAsFirst? I think DefineAsRegister would be more appropriate.

   return DefineSameAsFirst(result);
 }
 
@@ -1551,13 +1552,7 @@ LInstruction* LChunkBuilder::DoMod(HMod* instr) {
     return DoArithmeticT(Token::MOD, instr);
   } else {
     ASSERT(instr->representation().IsDouble());
-    // We call a C function for double modulo. It can't trigger a GC. We need
-    // to use fixed result register for the call.
-    // TODO(fschneider): Allow any register as input registers.
-    LArithmeticD* mod = new(zone()) LArithmeticD(Token::MOD,
-                                                 UseFixedDouble(left, xmm2),
-                                                 UseFixedDouble(right, xmm1));
-    return MarkAsCall(DefineFixedDouble(mod, xmm1), instr);
+    return DoArithmeticD(Token::MOD, instr);
   }
 }