Issue 21495005: Mod does not rely on a fixed register anymore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21495005: Mod does not rely on a fixed register anymore (Closed)

Created:
7 years, 4 months ago by oliv

Modified:
7 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

mod does not rely on a fixed register anymore, the arguments are passed via the stack. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16108

Patch Set 2 : address review #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -8 lines)			Patch
	M	src/ia32/lithium-ia32.cc	View	1	2 chunks	+3 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with comment. https://codereview.chromium.org/21495005/diff/1/src/ia32/lithium-ia32.cc File src/ia32/lithium-ia32.cc (right): https://codereview.chromium.org/21495005/diff/1/src/ia32/lithium-ia32.cc#newcode814 src/ia32/lithium-ia32.cc:814: if (op == Token::MOD) return MarkAsCall(DefineSameAsFirst(result), ...

7 years, 4 months ago (2013-08-01 11:42:15 UTC) #2

oliv

7 years, 4 months ago (2013-08-07 16:47:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r16108 (presubmit successful).

Expand Messages | Collapse Messages

Issue 21495005: Mod does not rely on a fixed register anymore (Closed)

Description

Patch Set 1 #

Patch Set 2 : address review #

Messages