Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 21495002: Revert windows-specific part of r15937 for debug level 1. (Closed)

Created:
7 years, 4 months ago by Michael Achenbach
Modified:
7 years, 4 months ago
CC:
v8-dev, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

Revert windows-specific part of r15937 for debug level 1. The change in r15937 might have broken a mozilla test under windows. See https://codereview.chromium.org/19384011/ Each case of debug 0,1,2 is now stated explicitly for better clarity in the msvs section. This causes some minor code duplications, which we can squeeze again after toolchain.gypi is in a stable state. R=dpranke@chromium.org, jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16018

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -11 lines) Patch
M build/toolchain.gypi View 3 chunks +32 lines, -11 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Michael Achenbach
PTAL
7 years, 4 months ago (2013-08-01 08:05:08 UTC) #1
Jakob Kummerow
lgtm
7 years, 4 months ago (2013-08-01 09:42:48 UTC) #2
Dirk Pranke
lgtm also. Did this fix the problem? https://codereview.chromium.org/21495002/diff/1/build/toolchain.gypi File build/toolchain.gypi (left): https://codereview.chromium.org/21495002/diff/1/build/toolchain.gypi#oldcode67 build/toolchain.gypi:67: # This ...
7 years, 4 months ago (2013-08-01 17:14:25 UTC) #3
Jakob Kummerow
On 2013/08/01 17:14:25, Dirk Pranke wrote: > lgtm also. Did this fix the problem? The ...
7 years, 4 months ago (2013-08-01 17:19:32 UTC) #4
Dirk Pranke
On 2013/08/01 17:19:32, Jakob wrote: > On 2013/08/01 17:14:25, Dirk Pranke wrote: > > lgtm ...
7 years, 4 months ago (2013-08-01 17:21:04 UTC) #5
Michael Achenbach
7 years, 4 months ago (2013-08-02 07:58:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r16018 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698