Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2149493005: X87: [Interpreter] Collect type feedback for calls in the bytecode handler. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Interpreter] Collect type feedback for calls in the bytecode handler. port fd420203ecb5abe427bda14aa896d90919d998fb (r37700) original commit message: Collect type feedback in the call bytecode handler. The current implementation only collects feedback for JS function objects. The other objects and Array functions do not collect any feedback. They will be marked Megamorphic. BUG= Committed: https://crrev.com/a3b38885548721f5d297d9f54be3794896e46407 Cr-Commit-Position: refs/heads/master@{#37737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M src/x87/builtins-x87.cc View 2 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-07-14 02:21:32 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-07-14 02:31:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149493005/1
4 years, 5 months ago (2016-07-14 02:32:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 02:53:56 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 02:57:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3b38885548721f5d297d9f54be3794896e46407
Cr-Commit-Position: refs/heads/master@{#37737}

Powered by Google App Engine
This is Rietveld 408576698