content/browser/renderer_host/render_widget_host_view_base.h - Issue 2149493004: [refactor] Removing the dead method RenderWidgetHostView::GetSelectedText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 2149493004: [refactor] Removing the dead method RenderWidgetHostView::GetSelectedText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Made const Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc ('K') | « content/browser/frame_host/render_widget_host_view_guest.cc ('k') | content/browser/renderer_host/render_widget_host_view_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_base.h

diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h

index 45edb87a630eaf86264d7162312844983b78f71d..f32b42debe854fc877deba4e61e8b38e7bd1a91e 100644

--- a/content/browser/renderer_host/render_widget_host_view_base.h

+++ b/content/browser/renderer_host/render_widget_host_view_base.h

@@ -92,7 +92,6 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,

void WasOccluded() override {}

bool IsShowingContextMenu() const override;

void SetShowingContextMenu(bool showing_menu) override;

- base::string16 GetSelectedText() const override;

bool IsMouseLocked() override;

gfx::Size GetVisibleViewportSize() const override;

void SetInsets(const gfx::Insets& insets) override;

@@ -396,6 +395,8 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,

virtual bool IsChildFrameForTesting() const;

virtual cc::SurfaceId SurfaceIdForTesting() const;

+ base::string16 GetSelectedTextForTesting() const;

Charlie Reis 2016/07/14 18:28:39 Won't this have the same problem when we get to ht

EhsanK 2016/07/14 19:09:17 Removed const. We will hopefully remove this metho

protected:

// Interface class only, do not construct.

RenderWidgetHostViewBase();