content/browser/frame_host/render_widget_host_view_guest.h - Issue 2149493004: [refactor] Removing the dead method RenderWidgetHostView::GetSelectedText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_guest.h

Issue 2149493004: [refactor] Removing the dead method RenderWidgetHostView::GetSelectedText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added the test back Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc ('k') | content/browser/frame_host/render_widget_host_view_guest.cc » ('j') | content/browser/renderer_host/render_widget_host_view_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_guest.h

diff --git a/content/browser/frame_host/render_widget_host_view_guest.h b/content/browser/frame_host/render_widget_host_view_guest.h

index 1be1dab94899add80cd20c982046dc07ec7277ea..13419ecebc51721b9bc77fa5e26466a706b84e10 100644

--- a/content/browser/frame_host/render_widget_host_view_guest.h

+++ b/content/browser/frame_host/render_widget_host_view_guest.h

@@ -68,7 +68,6 @@ class CONTENT_EXPORT RenderWidgetHostViewGuest

gfx::Rect GetViewBounds() const override;

gfx::Rect GetBoundsInRootWindow() override;

gfx::Size GetPhysicalBackingSize() const override;

- base::string16 GetSelectedText() const override;

// RenderWidgetHostViewBase implementation.

void InitAsPopup(RenderWidgetHostView* parent_host_view,