content/browser/renderer_host/render_widget_host_view_base.cc - Issue 2149493004: [refactor] Removing the dead method RenderWidgetHostView::GetSelectedText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.cc

Issue 2149493004: [refactor] Removing the dead method RenderWidgetHostView::GetSelectedText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed an interactive ui test from <webview> Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc ('K') | « content/browser/renderer_host/render_widget_host_view_base.h ('k') | content/browser/renderer_host/render_widget_host_view_mus.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_base.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc

index cd9a5cd36a252823d6dcf3052dd0bef9f5795c15..06d6848f7441322c3204008291eaab0aaefa710b 100644

--- a/content/browser/renderer_host/render_widget_host_view_base.cc

+++ b/content/browser/renderer_host/render_widget_host_view_base.cc

@@ -135,14 +135,6 @@ void RenderWidgetHostViewBase::SetShowingContextMenu(bool showing) {

showing_context_menu_ = showing;

}

-base::string16 RenderWidgetHostViewBase::GetSelectedText() const {

- if (!selection_range_.IsValid())

- return base::string16();

- return selection_text_.substr(

- selection_range_.GetMin() - selection_text_offset_,

- selection_range_.length());

bool RenderWidgetHostViewBase::IsMouseLocked() {

return mouse_locked_;

}