content/public/test/text_input_test_utils.h - Issue 2149493004: [refactor] Removing the dead method RenderWidgetHostView::GetSelectedText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/text_input_test_utils.h

Issue 2149493004: [refactor] Removing the dead method RenderWidgetHostView::GetSelectedText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call method on correct view Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_widget_host_view_guest.cc ('K') | « content/public/browser/render_widget_host_view.h ('k') | content/public/test/text_input_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/text_input_test_utils.h

diff --git a/content/public/test/text_input_test_utils.h b/content/public/test/text_input_test_utils.h

index 97b1da1a76da600d20012d722a49a0c3db3c35b0..04d53359b800b0b67bcc147c4db6d8b744ace95c 100644

--- a/content/public/test/text_input_test_utils.h

+++ b/content/public/test/text_input_test_utils.h

@@ -59,6 +59,13 @@ void SetCompositionForRenderWidgetHost(

int selection_start,

int selection_end);

+// This methods returns the current selection text for the |view|.

+// TODO(ekaramad): GetSelectedText() is based on an outdated API which is now

+// removed. After implementing IME for OOPIF, change this to use a more updated

+// API from TextInputManager.

+base::string16 GetSelectedTextForRenderWidgetHostView(

+ RenderWidgetHostView* view);

// This class provides the necessary API for accessing the state of and also

// observing the TextInputManager for WebContents.

class TextInputManagerTester {