[refactor] Removing the dead method RenderWidgetHostView::GetSelectedText()

content/browser/frame_host/render_widget_host_view_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_widget_host_view_guest.h"
 
 #include <utility>
 
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
@@ skipping 228 matching lines @@
   RenderWidgetHostViewChildFrame::Destroy();
 
   if (platform_view_)  // The platform view might have been destroyed already.
     platform_view_->Destroy();
 }
 
 gfx::Size RenderWidgetHostViewGuest::GetPhysicalBackingSize() const {
   return RenderWidgetHostViewBase::GetPhysicalBackingSize();
 }
 
-base::string16 RenderWidgetHostViewGuest::GetSelectedText() const {
-  return platform_view_->GetSelectedText();
-}
-
 void RenderWidgetHostViewGuest::SetTooltipText(
     const base::string16& tooltip_text) {
   if (guest_)
     guest_->SetTooltipText(tooltip_text);
 }
 
 void RenderWidgetHostViewGuest::OnSwapCompositorFrame(
     uint32_t output_surface_id,
     cc::CompositorFrame frame) {
   TRACE_EVENT0("content", "RenderWidgetHostViewGuest::OnSwapCompositorFrame");
@@ skipping 167 matching lines @@
         character_bounds[i].size()));
   }
   // Forward the information to embedding RWHV.
   rwhv->ImeCompositionRangeChanged(range, guest_character_bounds);
 }
 #endif
 
 void RenderWidgetHostViewGuest::SelectionChanged(const base::string16& text,
                                                  size_t offset,
                                                  const gfx::Range& range) {
+  // TODO(ekaramad): For the test WebViewInteractiveTest.TextSelection, we need
+  // to test the value of |selection_text_| by using the base class method
+  // GetSelectedTextForTesting(). This update makes sure we have the right
+  // value. This line along with the test method should be removed when issue
+  // crbug.com/578168 is fixed.
+  RenderWidgetHostViewBase::SelectionChanged(text, offset, range);

[Charlie Reis, 2016/07/14 22:45:06]

I don't think we should add this, if we can avoid it.  Seems like too much of a
hack to keep the test happy.

Is there any way the test could get to platform_view_->GetSelectedText()
directly?  Maybe have a guest-specific public test method, instead of the
general GetSelectedTextForRenderWidgetHostView?

+
   platform_view_->SelectionChanged(text, offset, range);
 }
 
 void RenderWidgetHostViewGuest::SelectionBoundsChanged(
     const ViewHostMsg_SelectionBounds_Params& params) {
   if (!guest_)
     return;
 
   RenderWidgetHostViewBase* rwhv = GetOwnerRenderWidgetHostView();
   if (!rwhv)
@@ skipping 170 matching lines @@
         gesture_event.data.scrollUpdate.inertialPhase ==
             blink::WebGestureEvent::MomentumPhase) {
       return;
     }
     host_->ForwardGestureEvent(gesture_event);
     return;
   }
 }
 
 }  // namespace content