Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2149493003: [turbofan] Fix deopt point for [[ToName]] lazy bailout. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix deopt point for [[ToName]] lazy bailout. This fixes the deoptimization information for the lazy bailout point after a [[ToName]] operation inserted for object literals and class literals. The result value was erroneously ignored. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-627828 BUG=chromium:627828 Committed: https://crrev.com/a2f1519f68f99275505c6891894790263662e3c2 Cr-Commit-Position: refs/heads/master@{#37719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -2 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-627828.js View 1 chunk +40 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
Michael Starzinger
4 years, 5 months ago (2016-07-13 14:36:22 UTC) #1
Jarin
lgtm, thanks!
4 years, 5 months ago (2016-07-13 15:01:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149493003/1
4 years, 5 months ago (2016-07-13 15:10:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 15:15:01 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 15:15:02 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 15:18:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2f1519f68f99275505c6891894790263662e3c2
Cr-Commit-Position: refs/heads/master@{#37719}

Powered by Google App Engine
This is Rietveld 408576698