Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2149463002: Remove unused StringImpl::findNextLineStart, StringImpl::count and reverseFindLineTerminator. (Closed)

Created:
4 years, 5 months ago by esprehn
Modified:
4 years, 5 months ago
Reviewers:
haraken, Yuta Kitamura
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused StringImpl::findNextLineStart, StringImpl::count and reverseFindLineTerminator. None of these is used anymore and we have no tests. Lets remove them and add them back later if/when they're needed. Committed: https://crrev.com/f40cd2fc77abf9743d69f898e32ef7fa09897c97 Cr-Commit-Position: refs/heads/master@{#405052}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -74 lines) Patch
M third_party/WebKit/Source/wtf/text/StringImpl.h View 2 chunks +0 lines, -51 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
esprehn
4 years, 5 months ago (2016-07-13 05:23:42 UTC) #4
esprehn
4 years, 5 months ago (2016-07-13 05:23:43 UTC) #5
haraken
LGTM
4 years, 5 months ago (2016-07-13 05:40:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149463002/1
4 years, 5 months ago (2016-07-13 05:53:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 06:03:22 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 06:05:20 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f40cd2fc77abf9743d69f898e32ef7fa09897c97
Cr-Commit-Position: refs/heads/master@{#405052}

Powered by Google App Engine
This is Rietveld 408576698