components/ntp_snippets/ntp_snippets_service.cc - Issue 2149453004: Implement first version of OfflinePageSuggestionsProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_service.cc

Issue 2149453004: Implement first version of OfflinePageSuggestionsProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove separate build target for offline_page_suggestions Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/ntp_snippets/ntp_snippets_service.cc

diff --git a/components/ntp_snippets/ntp_snippets_service.cc b/components/ntp_snippets/ntp_snippets_service.cc

index e13b8c32d3307316fb25ed6e6e163650915f3d1b..fc3ff800a0df056db1dfd871d2462c917971c4a1 100644

--- a/components/ntp_snippets/ntp_snippets_service.cc

+++ b/components/ntp_snippets/ntp_snippets_service.cc

@@ -222,6 +222,8 @@ NTPSnippetsService::NTPSnippetsService(

database_->SetErrorCallback(base::Bind(&NTPSnippetsService::OnDatabaseError,

base::Unretained(this)));

+ // TODO(pke): Move this to SetObserver as soon as the UI reads from the

+ // ContentSuggestionsService directly.

// We transition to other states while finalizing the initialization, when the

// database is done loading.

database_->LoadSnippets(base::Bind(&NTPSnippetsService::OnDatabaseLoaded,

« no previous file with comments | « components/ntp_snippets/ntp_snippets_service.h ('k') | components/ntp_snippets/offline_pages/DEPS » ('j') | no next file with comments »