chrome/browser/android/ntp/offline_page_suggestions_provider_factory.h - Issue 2149453004: Implement first version of OfflinePageSuggestionsProvider

Unified Diff: chrome/browser/android/ntp/offline_page_suggestions_provider_factory.h

Issue 2149453004: Implement first version of OfflinePageSuggestionsProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small fixes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/chrome_feature_list.cc ('K') | « chrome/browser/android/chrome_feature_list.cc ('k') | chrome/browser/android/ntp/offline_page_suggestions_provider_factory.cc » ('j') | components/ntp_snippets/offline_pages/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/ntp/offline_page_suggestions_provider_factory.h

diff --git a/chrome/browser/ntp_snippets/content_suggestions_service_factory.h b/chrome/browser/android/ntp/offline_page_suggestions_provider_factory.h

similarity index 51%

copy from chrome/browser/ntp_snippets/content_suggestions_service_factory.h

copy to chrome/browser/android/ntp/offline_page_suggestions_provider_factory.h

index e09f157f7e513c0d1b13a7b6df56c3e250cd1f56..d8bdd5e7f810ec30c40dc4679662dfb6163bd036 100644

--- a/chrome/browser/ntp_snippets/content_suggestions_service_factory.h

+++ b/chrome/browser/android/ntp/offline_page_suggestions_provider_factory.h

@@ -2,8 +2,8 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#ifndef CHROME_BROWSER_NTP_SNIPPETS_CONTENT_SUGGESTIONS_SERVICE_FACTORY_H_

-#define CHROME_BROWSER_NTP_SNIPPETS_CONTENT_SUGGESTIONS_SERVICE_FACTORY_H_

+#ifndef CHROME_BROWSER_ANDROID_NTP_OFFLINE_PAGE_SUGGESTIONS_PROVIDER_FACTORY_H_

+#define CHROME_BROWSER_ANDROID_NTP_OFFLINE_PAGE_SUGGESTIONS_PROVIDER_FACTORY_H_

#include <memory>

@@ -19,26 +19,28 @@ struct DefaultSingletonTraits;

namespace ntp_snippets {

class ContentSuggestionsService;

+class OfflinePageSuggestionsProvider;

} // namespace ntp_snippets

-class ContentSuggestionsServiceFactory

+class OfflinePageSuggestionsProviderFactory

: public BrowserContextKeyedServiceFactory {

public:

- static ContentSuggestionsServiceFactory* GetInstance();

- static ntp_snippets::ContentSuggestionsService* GetForProfile(

+ static OfflinePageSuggestionsProviderFactory* GetInstance();

+ static ntp_snippets::OfflinePageSuggestionsProvider* GetForProfile(

Profile* profile);

private:

- friend struct base::DefaultSingletonTraits<ContentSuggestionsServiceFactory>;

+ friend struct base::DefaultSingletonTraits<

+ OfflinePageSuggestionsProviderFactory>;

- ContentSuggestionsServiceFactory();

- ~ContentSuggestionsServiceFactory() override;

+ OfflinePageSuggestionsProviderFactory();

+ ~OfflinePageSuggestionsProviderFactory() override;

// BrowserStateKeyedServiceFactory implementation.

Bernhard Bauer 2016/07/14 18:47:43 Nit: This should be BrowserContextKeyedServiceFact

Philipp Keck 2016/07/15 09:08:42 Done. Changed this in a couple of other places, to

KeyedService* BuildServiceInstanceFor(

content::BrowserContext* context) const override;

- DISALLOW_COPY_AND_ASSIGN(ContentSuggestionsServiceFactory);

+ DISALLOW_COPY_AND_ASSIGN(OfflinePageSuggestionsProviderFactory);

};

-#endif // CHROME_BROWSER_NTP_SNIPPETS_CONTENT_SUGGESTIONS_SERVICE_FACTORY_H_

+#endif // CHROME_BROWSER_ANDROID_NTP_OFFLINE_PAGE_SUGGESTIONS_PROVIDER_FACTORY_H_