components/ntp_snippets/ntp_snippets_service.h - Issue 2149453004: Implement first version of OfflinePageSuggestionsProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_service.h

Issue 2149453004: Implement first version of OfflinePageSuggestionsProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move the factory to c/b/android/ntp and Marc's comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/ntp/offline_page_suggestions_provider_factory.cc ('K') | « components/ntp_snippets/content_suggestions_category.h ('k') | components/ntp_snippets/offline_pages/BUILD.gn » ('j') | components/ntp_snippets/offline_pages/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/ntp_snippets_service.h

diff --git a/components/ntp_snippets/ntp_snippets_service.h b/components/ntp_snippets/ntp_snippets_service.h

index 6e13c3c944775b372f72dbcadf93f504cb08fad9..16d3d6ff8d198c722d02c2f8a4c6e8f3dc3156f9 100644

--- a/components/ntp_snippets/ntp_snippets_service.h

+++ b/components/ntp_snippets/ntp_snippets_service.h

@@ -68,8 +68,6 @@ class NTPSnippetsService : public KeyedService,

public image_fetcher::ImageFetcherDelegate,

public ContentSuggestionsProvider {

public:

- using ImageFetchedCallback =

- base::Callback<void(const std::string& suggestion_id, const gfx::Image&)>;

Marc Treib 2016/07/14 14:17:24 nitty nit: also remove the empty line please :)

Philipp Keck 2016/07/14 15:30:06 Done.

// |application_language_code| should be a ISO 639-1 compliant string, e.g.

// 'en' or 'en-US'. Note that this code should only specify the language, not