Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: chrome/browser/android/chrome_feature_list.cc

Issue 2149453004: Implement first version of OfflinePageSuggestionsProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove separate build target for offline_page_suggestions Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/chrome_feature_list.h" 5 #include "chrome/browser/android/chrome_feature_list.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 17 matching lines...) Expand all
28 // in other locations in the code base (e.g. chrome/, components/, etc). 28 // in other locations in the code base (e.g. chrome/, components/, etc).
29 const base::Feature* kFeaturesExposedToJava[] = { 29 const base::Feature* kFeaturesExposedToJava[] = {
30 &features::kAutoplayMutedVideos, 30 &features::kAutoplayMutedVideos,
31 &features::kCredentialManagementAPI, 31 &features::kCredentialManagementAPI,
32 &features::kSimplifiedFullscreenUI, 32 &features::kSimplifiedFullscreenUI,
33 &kAndroidPayIntegrationV1, 33 &kAndroidPayIntegrationV1,
34 &kImportantSitesInCBD, 34 &kImportantSitesInCBD,
35 &kNTPFakeOmniboxTextFeature, 35 &kNTPFakeOmniboxTextFeature,
36 &kNTPMaterialDesign, 36 &kNTPMaterialDesign,
37 &kNTPOfflinePagesFeature, 37 &kNTPOfflinePagesFeature,
38 &kNTPOfflinePageSuggestionsFeature,
38 &kNTPSnippetsFeature, 39 &kNTPSnippetsFeature,
39 &kNTPToolbarFeature, 40 &kNTPToolbarFeature,
40 &kPhysicalWebFeature, 41 &kPhysicalWebFeature,
41 &kPhysicalWebIgnoreOtherClientsFeature, 42 &kPhysicalWebIgnoreOtherClientsFeature,
42 &kReadItLaterInMenu, 43 &kReadItLaterInMenu,
43 &kSystemDownloadManager, 44 &kSystemDownloadManager,
44 &offline_pages::kOfflinePagesBackgroundLoadingFeature, 45 &offline_pages::kOfflinePagesBackgroundLoadingFeature,
45 &offline_pages::kOfflinePagesCTFeature, // See crbug.com/620421. 46 &offline_pages::kOfflinePagesCTFeature, // See crbug.com/620421.
46 }; 47 };
47 48
48 } // namespace 49 } // namespace
49 50
50 const base::Feature kImportantSitesInCBD{"ImportantSitesInCBD", 51 const base::Feature kImportantSitesInCBD{"ImportantSitesInCBD",
51 base::FEATURE_DISABLED_BY_DEFAULT}; 52 base::FEATURE_DISABLED_BY_DEFAULT};
52 53
53 const base::Feature kNTPMaterialDesign{"NTPMaterialDesign", 54 const base::Feature kNTPMaterialDesign{"NTPMaterialDesign",
54 base::FEATURE_ENABLED_BY_DEFAULT}; 55 base::FEATURE_ENABLED_BY_DEFAULT};
55 56
56 const base::Feature kNTPOfflinePagesFeature { 57 const base::Feature kNTPOfflinePagesFeature{"NTPOfflinePages",
57 "NTPOfflinePages", base::FEATURE_DISABLED_BY_DEFAULT 58 base::FEATURE_DISABLED_BY_DEFAULT};
58 };
59 59
60 const base::Feature kNTPSnippetsFeature { 60 const base::Feature kNTPSnippetsFeature{"NTPSnippets",
61 "NTPSnippets", base::FEATURE_DISABLED_BY_DEFAULT 61 base::FEATURE_DISABLED_BY_DEFAULT};
62 };
63 62
64 const base::Feature kNTPToolbarFeature { 63 const base::Feature kNTPOfflinePageSuggestionsFeature{
65 "NTPToolbar", base::FEATURE_ENABLED_BY_DEFAULT 64 "NTPOfflinePageSuggestions", base::FEATURE_DISABLED_BY_DEFAULT};
66 };
67 65
68 const base::Feature kNTPFakeOmniboxTextFeature { 66 const base::Feature kNTPToolbarFeature{"NTPToolbar",
69 "NTPFakeOmniboxText", base::FEATURE_DISABLED_BY_DEFAULT 67 base::FEATURE_ENABLED_BY_DEFAULT};
70 };
71 68
72 const base::Feature kAndroidPayIntegrationV1 { 69 const base::Feature kNTPFakeOmniboxTextFeature{
73 "AndroidPayIntegrationV1", base::FEATURE_ENABLED_BY_DEFAULT 70 "NTPFakeOmniboxText", base::FEATURE_DISABLED_BY_DEFAULT};
74 };
75 71
76 const base::Feature kPhysicalWebFeature { 72 const base::Feature kAndroidPayIntegrationV1{"AndroidPayIntegrationV1",
77 "PhysicalWeb", base::FEATURE_ENABLED_BY_DEFAULT 73 base::FEATURE_ENABLED_BY_DEFAULT};
78 };
79 74
80 const base::Feature kPhysicalWebIgnoreOtherClientsFeature { 75 const base::Feature kPhysicalWebFeature{"PhysicalWeb",
81 "PhysicalWebIgnoreOtherClients", base::FEATURE_DISABLED_BY_DEFAULT 76 base::FEATURE_ENABLED_BY_DEFAULT};
82 };
83 77
84 const base::Feature kReadItLaterInMenu { 78 const base::Feature kPhysicalWebIgnoreOtherClientsFeature{
85 "ReadItLaterInMenu", base::FEATURE_DISABLED_BY_DEFAULT 79 "PhysicalWebIgnoreOtherClients", base::FEATURE_DISABLED_BY_DEFAULT};
86 };
87 80
88 const base::Feature kSystemDownloadManager { 81 const base::Feature kReadItLaterInMenu{"ReadItLaterInMenu",
89 "SystemDownloadManager", base::FEATURE_ENABLED_BY_DEFAULT 82 base::FEATURE_DISABLED_BY_DEFAULT};
90 }; 83
84 const base::Feature kSystemDownloadManager{"SystemDownloadManager",
85 base::FEATURE_ENABLED_BY_DEFAULT};
91 86
92 static jboolean IsEnabled(JNIEnv* env, 87 static jboolean IsEnabled(JNIEnv* env,
93 const JavaParamRef<jclass>& clazz, 88 const JavaParamRef<jclass>& clazz,
94 const JavaParamRef<jstring>& jfeature_name) { 89 const JavaParamRef<jstring>& jfeature_name) {
95 const std::string feature_name = ConvertJavaStringToUTF8(env, jfeature_name); 90 const std::string feature_name = ConvertJavaStringToUTF8(env, jfeature_name);
96 for (size_t i = 0; i < arraysize(kFeaturesExposedToJava); ++i) { 91 for (size_t i = 0; i < arraysize(kFeaturesExposedToJava); ++i) {
97 if (kFeaturesExposedToJava[i]->name == feature_name) 92 if (kFeaturesExposedToJava[i]->name == feature_name)
98 return base::FeatureList::IsEnabled(*kFeaturesExposedToJava[i]); 93 return base::FeatureList::IsEnabled(*kFeaturesExposedToJava[i]);
99 } 94 }
100 // Features queried via this API must be present in |kFeaturesExposedToJava|. 95 // Features queried via this API must be present in |kFeaturesExposedToJava|.
101 NOTREACHED(); 96 NOTREACHED();
102 return false; 97 return false;
103 } 98 }
104 99
105 bool RegisterChromeFeatureListJni(JNIEnv* env) { 100 bool RegisterChromeFeatureListJni(JNIEnv* env) {
106 return RegisterNativesImpl(env); 101 return RegisterNativesImpl(env);
107 } 102 }
108 103
109 } // namespace android 104 } // namespace android
110 } // namespace chrome 105 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/android/chrome_feature_list.h ('k') | chrome/browser/android/ntp/offline_page_suggestions_provider_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698