components/ntp_snippets/offline_pages/BUILD.gn - Issue 2149453004: Implement first version of OfflinePageSuggestionsProvider

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ntp_snippets/offline_pages/BUILD.gn

Issue 2149453004: Implement first version of OfflinePageSuggestionsProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move the factory to c/b/android/ntp and Marc's comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/ntp_snippets/ntp_snippets_service.h ('K') | « components/ntp_snippets/ntp_snippets_service.h ('k') | components/ntp_snippets/offline_pages/DEPS » ('j') | components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 # GYP: //components/ntp_snippets.gypi:offline_page_suggestions

	6 static_library("offline_page_suggestions") {

	7 sources = [

	8 "offline_page_suggestions_provider.cc",

	9 "offline_page_suggestions_provider.h",

	10 ]

	11

	12 deps = [

	13 "//base",

	14 "//components/keyed_service/core",

	15 "//components/ntp_snippets:ntp_snippets",

	16 "//components/offline_pages:offline_pages",

	17 ]

	18 }

	19

	20 source_set("unit_tests") {
	Marc Treib 2016/07/14 14:17:24 Do you have any unit tests for this yet? If not, l Do you have any unit tests for this yet? If not, leave this out until you do. Philipp Keck 2016/07/14 15:30:06 Done. Show quoted text On 2016/07/14 14:17:24, Marc Treib wrote: > Do you have any unit tests for this yet? If not, leave this out until you do. Done.
	21 testonly = true

	22 sources = []

	23

	24 deps = [

	25 ":offline_page_suggestions",

	26 "//base",

	27 "//base/test:test_support",

	28 "//components/ntp_snippets:ntp_snippets",

	29 "//components/offline_pages",

	30 "//testing/gtest",

	31 ]

	32 }

OLD	NEW