Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2149453004: Implement first version of OfflinePageSuggestionsProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move the factory to c/b/android/ntp and Marc's comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1806 matching lines...) Expand 10 before | Expand all | Expand 10 after
1817 IDS_FLAG_DISABLE_DESKTOP_CAPTURE_PICKER_NEW_UI_DESCRIPTION, kOsAll, 1817 IDS_FLAG_DISABLE_DESKTOP_CAPTURE_PICKER_NEW_UI_DESCRIPTION, kOsAll,
1818 SINGLE_VALUE_TYPE( 1818 SINGLE_VALUE_TYPE(
1819 extensions::switches::kDisableDesktopCapturePickerNewUI)}, 1819 extensions::switches::kDisableDesktopCapturePickerNewUI)},
1820 #endif 1820 #endif
1821 #if defined(OS_ANDROID) 1821 #if defined(OS_ANDROID)
1822 {"enable-ntp-snippets", IDS_FLAGS_ENABLE_NTP_SNIPPETS_NAME, 1822 {"enable-ntp-snippets", IDS_FLAGS_ENABLE_NTP_SNIPPETS_NAME,
1823 IDS_FLAGS_ENABLE_NTP_SNIPPETS_DESCRIPTION, kOsAndroid, 1823 IDS_FLAGS_ENABLE_NTP_SNIPPETS_DESCRIPTION, kOsAndroid,
1824 FEATURE_WITH_VARIATIONS_VALUE_TYPE(chrome::android::kNTPSnippetsFeature, 1824 FEATURE_WITH_VARIATIONS_VALUE_TYPE(chrome::android::kNTPSnippetsFeature,
1825 kNTPSnippetsFeatureVariations, 1825 kNTPSnippetsFeatureVariations,
1826 ntp_snippets::kStudyName)}, 1826 ntp_snippets::kStudyName)},
1827 {"enable-ntp-offline-page-suggestions",
1828 IDS_FLAGS_ENABLE_NTP_OFFLINE_PAGE_SUGGESTIONS_NAME,
1829 IDS_FLAGS_ENABLE_NTP_OFFLINE_PAGE_SUGGESTIONS_DESCRIPTION, kOsAndroid,
1830 FEATURE_VALUE_TYPE(chrome::android::kNTPOfflinePageSuggestionsFeature)},
1827 #endif // defined(OS_ANDROID) 1831 #endif // defined(OS_ANDROID)
1828 #if defined(ENABLE_WEBRTC) && BUILDFLAG(RTC_USE_H264) 1832 #if defined(ENABLE_WEBRTC) && BUILDFLAG(RTC_USE_H264)
1829 {"enable-webrtc-h264-with-openh264-ffmpeg", 1833 {"enable-webrtc-h264-with-openh264-ffmpeg",
1830 IDS_FLAGS_WEBRTC_H264_WITH_OPENH264_FFMPEG_NAME, 1834 IDS_FLAGS_WEBRTC_H264_WITH_OPENH264_FFMPEG_NAME,
1831 IDS_FLAGS_WEBRTC_H264_WITH_OPENH264_FFMPEG_DESCRIPTION, kOsDesktop, 1835 IDS_FLAGS_WEBRTC_H264_WITH_OPENH264_FFMPEG_DESCRIPTION, kOsDesktop,
1832 FEATURE_VALUE_TYPE(content::kWebRtcH264WithOpenH264FFmpeg)}, 1836 FEATURE_VALUE_TYPE(content::kWebRtcH264WithOpenH264FFmpeg)},
1833 #endif // defined(ENABLE_WEBRTC) && BUILDFLAG(RTC_USE_H264) 1837 #endif // defined(ENABLE_WEBRTC) && BUILDFLAG(RTC_USE_H264)
1834 #if defined(OS_ANDROID) 1838 #if defined(OS_ANDROID)
1835 {"ime-thread", IDS_FLAGS_IME_THREAD_NAME, IDS_FLAGS_IME_THREAD_DESCRIPTION, 1839 {"ime-thread", IDS_FLAGS_IME_THREAD_NAME, IDS_FLAGS_IME_THREAD_DESCRIPTION,
1836 kOsAndroid, FEATURE_VALUE_TYPE(features::kImeThread)}, 1840 kOsAndroid, FEATURE_VALUE_TYPE(features::kImeThread)},
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
2142 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2146 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2143 2147
2144 const FeatureEntry* GetFeatureEntries(size_t* count) { 2148 const FeatureEntry* GetFeatureEntries(size_t* count) {
2145 *count = arraysize(kFeatureEntries); 2149 *count = arraysize(kFeatureEntries);
2146 return kFeatureEntries; 2150 return kFeatureEntries;
2147 } 2151 }
2148 2152
2149 } // namespace testing 2153 } // namespace testing
2150 2154
2151 } // namespace about_flags 2155 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698