Implement first version of OfflinePageSuggestionsProvider

components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h"
+
+#include "base/bind.h"
+#include "base/strings/stringprintf.h"
+
+using offline_pages::MultipleOfflinePageItemResult;
+using offline_pages::OfflinePageModel;
+using offline_pages::OfflinePageItem;
+
+namespace ntp_snippets {
+
+OfflinePageSuggestionsProvider::OfflinePageSuggestionsProvider(
+    OfflinePageModel* offline_page_model)
+    : ContentSuggestionsProvider({ContentSuggestionsCategory::OFFLINE_PAGES}),
+      category_status_(ContentSuggestionsCategoryStatus::AVAILABLE_LOADING),
+      offline_page_model_(offline_page_model) {
+  offline_page_model_->AddObserver(this);
+  FetchOfflinePages();
+}
+
+OfflinePageSuggestionsProvider::~OfflinePageSuggestionsProvider() {}
+
+// Inherited from KeyedService.
+void OfflinePageSuggestionsProvider::Shutdown() {
+  offline_page_model_->RemoveObserver(this);
+  category_status_ = ContentSuggestionsCategoryStatus::NOT_PROVIDED;
+}
+
+////////////////////////////////////////////////////////////////////////////////
+// Private methods
+
+void OfflinePageSuggestionsProvider::SetObserver(
+    ContentSuggestionsProvider::Observer* observer) {
+  observer_ = observer;
+}
+
+ContentSuggestionsCategoryStatus
+OfflinePageSuggestionsProvider::GetCategoryStatus(
+    ContentSuggestionsCategory category) {
+  // TODO(pke) Is this ok?

[Marc Treib, 2016/07/14 12:16:53]

nit: "TODO(pke):" (add colon)

[Philipp Keck, 2016/07/14 13:46:02]

Done.

+  return ContentSuggestionsCategoryStatus::AVAILABLE;

[Marc Treib, 2016/07/14 12:16:53]

Why not "return category_status_;" ?

[Philipp Keck, 2016/07/14 13:46:02]

Done.

I had changed this entire method when I introduced category_status_, but that
must have gone missing during some rebase.

+}
+
+void OfflinePageSuggestionsProvider::DiscardSuggestion(
+    const std::string& suggestion_id) {
+  // TODO(pke) Implement some "dont show on NTP anymore" behaviour,
+  // then also implement ClearDiscardedSuggestionsForDebugging.
+}
+
+void OfflinePageSuggestionsProvider::FetchSuggestionImage(
+    const std::string& suggestion_id,
+    const ImageFetchedCallback& callback) {
+  // TODO(pke) Implement
+}
+
+void OfflinePageSuggestionsProvider::ClearCachedSuggestionsForDebugging() {
+  // Ignore
+}
+
+void OfflinePageSuggestionsProvider::ClearDiscardedSuggestionsForDebugging() {
+  // Ignore
+}
+
+void OfflinePageSuggestionsProvider::OfflinePageModelLoaded(
+    OfflinePageModel* model) {
+  // Ignore (when offline pages have been loaded, OnOfflinePagesLoaded will be

[Marc Treib, 2016/07/14 12:16:53]

nit: DCHECK that model is the same that we have?

[Philipp Keck, 2016/07/14 13:46:02]

Done.

+  // called as a delayed callback, see ctor).
+}
+
+void OfflinePageSuggestionsProvider::OfflinePageModelChanged(
+    OfflinePageModel* model) {
+  FetchOfflinePages();
+}
+
+void OfflinePageSuggestionsProvider::OfflinePageDeleted(
+    int64_t offline_id,
+    const offline_pages::ClientId& client_id) {
+  // TODO(pke) Implement (does the ofp have to be cleared from UI immediately?)

[Marc Treib, 2016/07/14 12:16:53]

It should be, yes (the card will link to the offline page directly, which won't
exist anymore).
(Of course, it's fine to leave this as a TODO for now)

[Philipp Keck, 2016/07/14 13:46:02]

Done.

+}
+
+void OfflinePageSuggestionsProvider::FetchOfflinePages() {
+  offline_page_model_->GetAllPages(
+      base::Bind(&OfflinePageSuggestionsProvider::OnOfflinePagesLoaded,
+                 base::Unretained(this)));
+}
+
+void OfflinePageSuggestionsProvider::OnOfflinePagesLoaded(
+    const MultipleOfflinePageItemResult& result) {
+  if (!observer_) {
+    category_status_ = ContentSuggestionsCategoryStatus::AVAILABLE;
+    return;
+  }
+
+  if (category_status_ != ContentSuggestionsCategoryStatus::AVAILABLE) {
+    category_status_ = ContentSuggestionsCategoryStatus::AVAILABLE;
+    observer_->OnCategoryStatusChanged(
+        ContentSuggestionsCategory::OFFLINE_PAGES, category_status_);
+  }
+
+  std::vector<ContentSuggestion> suggestions;
+  for (const OfflinePageItem& item : result) {
+    ContentSuggestion suggestion = ContentSuggestion(

[Marc Treib, 2016/07/14 12:16:53]

nit: Just "ContentSuggestions suggestion(...)"

[Philipp Keck, 2016/07/14 13:46:02]

Done.

+        MakeUniqueID(ContentSuggestionsCategory::OFFLINE_PAGES,
+                     std::to_string(item.offline_id)),
+        item.GetOfflineURL());
+
+    // TODO(pke): Sort my most recently visited and only keep the top one of
+    // multiple entries for the same URL.
+    // TODO(pke): Get more reasonable data from the OfflinePageModel here.
+    suggestion.set_title(item.url.spec());
+    suggestion.set_snippet_text(std::string());
+    suggestion.set_publish_date(item.creation_time);
+    suggestion.set_publisher_name(item.url.host());
+    suggestions.emplace_back(std::move(suggestion));
+  }
+
+  observer_->OnNewSuggestions(ContentSuggestionsCategory::OFFLINE_PAGES,
+                              std::move(suggestions));
+}
+
+}  // namespace ntp_snippets