Implement first version of OfflinePageSuggestionsProvider

components/ntp_snippets/offline_pages/BUILD.gn

+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+if (is_android) {
+  import("//build/config/android/config.gni")
+  import("//build/config/android/rules.gni")

[Marc Treib, 2016/07/14 12:16:53]

Required?

[Philipp Keck, 2016/07/14 13:46:02]

Done.

[Marc Treib, 2016/07/14 14:17:23]

Hm, the config one should probably stay. Let's see what the more Android-savvy
folks say.

[Philipp Keck, 2016/07/14 15:30:06]

Acknowledged.

+}
+
+# GYP: //components/ntp_snippets.gypi:offline_page_suggestions
+static_library("offline_page_suggestions") {

[Marc Treib, 2016/07/14 12:16:53]

nit: Should this have the same name as the folder?

[Philipp Keck, 2016/07/14 13:46:02]

It would then be confused more easily with the components/offline_pages one.

[Marc Treib, 2016/07/14 14:17:23]

Acknowledged.

+  sources = [
+    "offline_page_suggestions_provider.cc",
+    "offline_page_suggestions_provider.h",
+  ]
+
+  deps = [
+    "//base",
+    "//components/keyed_service/core",
+    "//components/ntp_snippets:ntp_snippets",
+    "//components/offline_pages:offline_pages",

[Marc Treib, 2016/07/14 12:16:53]

nit: I think the ":offline_pages" etc isn't required, if it's the same as the
last path component

[Philipp Keck, 2016/07/14 13:46:02]

Done.

[Marc Treib, 2016/07/14 14:17:23]

No, not done actually. There's a few places here what the comment applies :)

[Philipp Keck, 2016/07/14 15:30:06]

Done. ...

+  ]
+}
+
+source_set("unit_tests") {
+  testonly = true
+  sources = []
+
+  deps = [
+    ":offline_page_suggestions",
+    "//base",
+    "//base/test:test_support",
+    "//components/ntp_snippets:ntp_snippets",
+    "//components/offline_pages:offline_pages",
+    "//testing/gtest",
+  ]
+}