Implement first version of OfflinePageSuggestionsProvider

components/ntp_snippets.gypi

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       # GN version: //components/ntp_snippets
       'target_name': 'ntp_snippets',
       'type': 'static_library',
@@ skipping 44 matching lines @@
         'ntp_snippets/proto/ntp_snippets.proto',
         'ntp_snippets/switches.cc',
         'ntp_snippets/switches.h',
       ],
       'variables': {
         'proto_in_dir': 'ntp_snippets/proto',
         'proto_out_dir': 'components/ntp_snippets/proto',
       },
       'includes': [ '../build/protoc.gypi' ],
     },
+    {
+      # GN: //components/ntp_snippets/offline_pages:offline_page_suggestions
+      'target_name': 'ntp_snippets_offline_page_suggestions',
+      'type': 'static_library',
+      'include_dirs': [
+        '..',
+        '../..',

[Marc Treib, 2016/07/14 12:16:53]

Is this required?

[Philipp Keck, 2016/07/14 13:46:02]

I don't know. It's inspired by this:
https://codesearch.chromium.org/chromium/src/components/offline_pages.gypi?q=...
but I don't know how to run the GYP build to try it out. Someone recently said
that the GYP build wasn't supported for Android anyway?

[Marc Treib, 2016/07/14 16:13:16]

I'm pretty sure gyp is still supported everywhere, though it won't be for much
longer. You can run gyp with build/gyp_chromium, see e.g.
http://dev.chromium.org/developers/gyp-environment-variables

Anyway, it doesn't really matter. If it builds, then it's fine.

[Bernhard Bauer, 2016/07/14 18:47:43]

On Android there aren't any bits that still build with GYP, so it's effectively
unsupported. 

Also +1, the '..' include seems very strange, and the '../..' include (which is
the src root, right?) should already be there, I think. Why do we need a
separate target anyway?

[Philipp Keck, 2016/07/15 09:08:41]

I'm not an expert on GYP build files. The reason why this is here is this:
https://codesearch.chromium.org/chromium/src/components/offline_pages.gypi?q=...

So you're saying I can remove the entire include_dirs, if not the entire target
here (and then include the files in the above target instead)?

[Philipp Keck, 2016/07/15 09:08:41]

Acknowledged.

[Bernhard Bauer, 2016/07/18 11:09:32]

Yup. offline_pages_background_offliner is kind of a weird case anyway, as it
only seems to be a dependency of a test target...

[Philipp Keck, 2016/07/18 12:55:03]

Done.

+      ],
+      'dependencies': [
+        '../base/base.gyp:base',
+        'keyed_service_core',
+        'ntp_snippets',
+        'offline_pages',
+      ],
+      'sources': [
+        'ntp_snippets/offline_pages/offline_page_suggestions_provider.cc',
+        'ntp_snippets/offline_pages/offline_page_suggestions_provider.h',
+      ],
+    },
   ],
 }