Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: src/core/SkRasterPipeline.h

Issue 2149443002: SkRasterPipeline: simplify impl and remove need to rewire stages (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkRasterPipeline.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkRasterPipeline.h
diff --git a/src/core/SkRasterPipeline.h b/src/core/SkRasterPipeline.h
index 8ae7bb1f2ed1782ebda39683f35874212386ffa4..186ee654c206451f2c9831297f2d58afd8029d91 100644
--- a/src/core/SkRasterPipeline.h
+++ b/src/core/SkRasterPipeline.h
@@ -96,9 +96,16 @@ public:
private:
using Stages = SkSTArray<10, Stage, /*MEM_COPY=*/true>;
+ // This no-op default makes fBodyStart and fTailStart unconditionally safe to call,
+ // and is always the last stage's fNext as a sort of safety net to make sure even a
+ // buggy pipeline can't walk off its own end.
+ static void SK_VECTORCALL JustReturn(Stage*, size_t, Sk4f,Sk4f,Sk4f,Sk4f,
+ Sk4f,Sk4f,Sk4f,Sk4f);
+
Stages fBody,
fTail;
- bool fReadyToRun = false;
+ Fn fBodyStart = &JustReturn,
+ fTailStart = &JustReturn;
};
#endif//SkRasterPipeline_DEFINED
« no previous file with comments | « no previous file | src/core/SkRasterPipeline.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698