SkRasterPipeline: simplify impl and remove need to rewire stages

SkRasterPipeline: simplify impl and remove need to rewire stages

This builds the stages correctly wired from the get-go.  With a little clever
setup, we can also design around the previous error cases like having no stages
or pipelines that call st->next() off the end.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2149443002

Committed: https://skia.googlesource.com/skia/+/0abddf7bb7f77b1ff6a48efc9d1eafd053d975d2

[mtklein_C, 2016-07-13 03:15:58]

Description was changed from

==========
SkRasterPipeline: simplify impl and remove need to rewire stages

This builds the stages correctly wired from the get-go.  With a little clever
setup, we can design around the previous edge cases like having no stages.

BUG=skia:
==========

to

==========
SkRasterPipeline: simplify impl and remove need to rewire stages

This builds the stages correctly wired from the get-go.  With a little clever
setup, we can design around the previous edge cases like having no stages.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2149443002
==========

[mtklein, 2016-07-13 03:17:03]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 03:17:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-07-13 03:20:52]

Description was changed from

==========
SkRasterPipeline: simplify impl and remove need to rewire stages

This builds the stages correctly wired from the get-go.  With a little clever
setup, we can design around the previous edge cases like having no stages.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2149443002
==========

to

==========
SkRasterPipeline: simplify impl and remove need to rewire stages

This builds the stages correctly wired from the get-go.  With a little clever
setup, we can design around the previous edge cases like having no stages too.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2149443002
==========

[mtklein_C, 2016-07-13 03:28:11]

Description was changed from

==========
SkRasterPipeline: simplify impl and remove need to rewire stages

This builds the stages correctly wired from the get-go.  With a little clever
setup, we can design around the previous edge cases like having no stages too.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2149443002
==========

to

==========
SkRasterPipeline: simplify impl and remove need to rewire stages

This builds the stages correctly wired from the get-go.  With a little clever
setup, we can also design around the previous edge cases like having no stages
or pipelines that call st->next() off the end.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2149443002
==========

[mtklein_C, 2016-07-13 03:32:13]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 03:32:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-07-13 03:35:33]

Description was changed from

==========
SkRasterPipeline: simplify impl and remove need to rewire stages

This builds the stages correctly wired from the get-go.  With a little clever
setup, we can also design around the previous edge cases like having no stages
or pipelines that call st->next() off the end.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2149443002
==========

to

==========
SkRasterPipeline: simplify impl and remove need to rewire stages

This builds the stages correctly wired from the get-go.  With a little clever
setup, we can also design around the previous error cases like having no stages
or pipelines that call st->next() off the end.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2149443002
==========

[mtklein_C, 2016-07-13 03:37:20]

mtklein@chromium.org changed reviewers:
+ herb@google.com
- mtklein@google.com

[mtklein_C, 2016-07-13 03:37:21]

So much simpler!

[commit-bot: I haz the power, 2016-07-13 03:50:14]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 03:50:15]

Dry run: This issue passed the CQ dry run.

[herb_g, 2016-07-13 14:28:21]

lgtm

https://codereview.chromium.org/2149443002/diff/40001/src/core/SkRasterPipeli...
File src/core/SkRasterPipeline.cpp (right):

https://codereview.chromium.org/2149443002/diff/40001/src/core/SkRasterPipeli...
src/core/SkRasterPipeline.cpp:14: (fBody.empty() ? fBodyStart :
fBody.back().fNext) = body_fn;
A comment here about how the stages are threaded together would be helpful.

[mtklein_C, 2016-07-13 14:50:14]

On 2016/07/13 at 14:28:21, herb wrote:
> lgtm
> 
>
https://codereview.chromium.org/2149443002/diff/40001/src/core/SkRasterPipeli...
> File src/core/SkRasterPipeline.cpp (right):
> 
>
https://codereview.chromium.org/2149443002/diff/40001/src/core/SkRasterPipeli...
> src/core/SkRasterPipeline.cpp:14: (fBody.empty() ? fBodyStart :
fBody.back().fNext) = body_fn;
> A comment here about how the stages are threaded together would be helpful.

Done.

[mtklein_C, 2016-07-13 14:50:17]

The CQ bit was checked by mtklein@chromium.org

[mtklein_C, 2016-07-13 14:50:17]

The patchset sent to the CQ was uploaded after l-g-t-m from herb@google.com
Link to the patchset: https://codereview.chromium.org/2149443002/#ps60001
(title: "comments")

[commit-bot: I haz the power, 2016-07-13 14:50:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 15:22:22]

Description was changed from

==========
SkRasterPipeline: simplify impl and remove need to rewire stages

This builds the stages correctly wired from the get-go.  With a little clever
setup, we can also design around the previous error cases like having no stages
or pipelines that call st->next() off the end.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2149443002
==========

to

==========
SkRasterPipeline: simplify impl and remove need to rewire stages

This builds the stages correctly wired from the get-go.  With a little clever
setup, we can also design around the previous error cases like having no stages
or pipelines that call st->next() off the end.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2149443002

Committed:
https://skia.googlesource.com/skia/+/0abddf7bb7f77b1ff6a48efc9d1eafd053d975d2
==========

[commit-bot: I haz the power, 2016-07-13 15:22:23]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/0abddf7bb7f77b1ff6a48efc9d1eafd053d975d2