Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2149393002: Rename ElementRareData::ensureComputedStyle (Closed)

Created:
4 years, 5 months ago by Bugs Nash
Modified:
4 years, 5 months ago
Reviewers:
esprehn, sashab, shans
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ElementRareData::ensureComputedStyle Renamed to ElementRareData::computedStyle. ElementRareData::ensureComputedStyle is simply a getter so ElementRareData::computedStyle is a more accurate name. Committed: https://crrev.com/7196728d3e67eb3869caef2e2052794cc259271c Cr-Commit-Position: refs/heads/master@{#405711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ElementRareData.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
Bugs Nash
4 years, 5 months ago (2016-07-15 05:49:45 UTC) #4
sashab
lgtm
4 years, 5 months ago (2016-07-15 05:51:56 UTC) #5
shans
lgtm
4 years, 5 months ago (2016-07-15 05:52:21 UTC) #8
Bugs Nash
Elliott ptal
4 years, 5 months ago (2016-07-15 06:06:06 UTC) #11
sashab
Haha my bad shane isn't OWNERs of style!! XD Esprehn please rs
4 years, 5 months ago (2016-07-15 06:17:23 UTC) #12
esprehn
lgtm
4 years, 5 months ago (2016-07-15 06:18:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149393002/1
4 years, 5 months ago (2016-07-15 06:55:58 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 06:59:56 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 07:00:07 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 07:01:32 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7196728d3e67eb3869caef2e2052794cc259271c
Cr-Commit-Position: refs/heads/master@{#405711}

Powered by Google App Engine
This is Rietveld 408576698