Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2149343002: AX hittest shouldn't crash when <option> element doesn't have corresponding <select> (Closed)

Created:
4 years, 5 months ago by kouhei (in TOK)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, nektarios, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews, dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AX hittest shouldn't crash when <option> element doesn't have corresponding <select> BUG=628335 Committed: https://crrev.com/662ce750c07b7497103d64041cd5a30a9ed90b5c Cr-Commit-Position: refs/heads/master@{#405698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/accessibility/accessibility-hit-test-crash.html View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/accessibility/accessibility-hit-test-crash-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
kouhei (in TOK)
haraken,dominicc: Would you take a look? dmazzoni is OOO
4 years, 5 months ago (2016-07-15 02:02:36 UTC) #2
kouhei (in TOK)
+tasak for AX
4 years, 5 months ago (2016-07-15 02:02:54 UTC) #4
tasak
lgtm
4 years, 5 months ago (2016-07-15 02:06:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149343002/1
4 years, 5 months ago (2016-07-15 02:09:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/218658)
4 years, 5 months ago (2016-07-15 02:17:50 UTC) #9
haraken
LGTM
4 years, 5 months ago (2016-07-15 02:28:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149343002/1
4 years, 5 months ago (2016-07-15 03:15:02 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 04:33:39 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 04:33:46 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 04:35:30 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/662ce750c07b7497103d64041cd5a30a9ed90b5c
Cr-Commit-Position: refs/heads/master@{#405698}

Powered by Google App Engine
This is Rietveld 408576698