Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java

Issue 2149333003: 📰 Adjust the card display depending on the screen width. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ZineTabletUI
Patch Set: address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java
index 28ec164bb7f56cc8b4abbc45f595964659421568..9aaa0554dced32ff34a6a744ab4a2af4f0da7bb9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java
@@ -6,10 +6,10 @@
import android.support.v7.widget.RecyclerView;
import android.view.LayoutInflater;
-import android.view.View;
-import android.view.ViewGroup;
import org.chromium.chrome.R;
+import org.chromium.chrome.browser.ntp.UiConfig;
+import org.chromium.chrome.browser.ntp.cards.MarginResizer;
import org.chromium.chrome.browser.ntp.cards.NewTabPageListItem;
import org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerView;
import org.chromium.chrome.browser.ntp.cards.NewTabPageViewHolder;
@@ -27,20 +27,17 @@
private SnippetHeaderListItem mHeader;
- public static View createView(ViewGroup parent) {
- return LayoutInflater.from(parent.getContext())
- .inflate(R.layout.new_tab_page_snippets_card, parent, false);
- }
-
- public SnippetHeaderViewHolder(final View cardView, final NewTabPageRecyclerView recyclerView) {
- super(cardView);
- mMaxSnippetHeaderHeight = cardView.getResources().getDimensionPixelSize(
+ public SnippetHeaderViewHolder(final NewTabPageRecyclerView recyclerView, UiConfig config) {
+ super(LayoutInflater.from(recyclerView.getContext())
+ .inflate(R.layout.new_tab_page_snippets_header, recyclerView, false));
+ mMaxSnippetHeaderHeight = itemView.getResources().getDimensionPixelSize(
R.dimen.snippets_article_header_height);
- mMaxPeekPadding = cardView.getResources().getDimensionPixelSize(
+ mMaxPeekPadding = itemView.getResources().getDimensionPixelSize(
R.dimen.snippets_padding_and_peeking_card_height);
mRecyclerView = recyclerView;
+ MarginResizer.createWithViewAdapter(itemView, config);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698