Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2379)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

Issue 2149333003: 📰 Adjust the card display depending on the screen width. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ZineTabletUI
Patch Set: address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
index a7a67e61d4c9ed3211366943092c1ae1d492a508..3b007b9deadd592a1f96533309f191458ac5d5b5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
@@ -24,8 +24,10 @@
import org.chromium.chrome.R;
import org.chromium.chrome.browser.favicon.FaviconHelper.FaviconImageCallback;
import org.chromium.chrome.browser.favicon.FaviconHelper.IconAvailabilityCallback;
+import org.chromium.chrome.browser.ntp.DisplayStyleObserver;
import org.chromium.chrome.browser.ntp.NewTabPage;
import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
+import org.chromium.chrome.browser.ntp.UiConfig;
import org.chromium.chrome.browser.ntp.cards.CardViewHolder;
import org.chromium.chrome.browser.ntp.cards.NewTabPageListItem;
import org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerView;
@@ -72,7 +74,7 @@
*/
public SnippetArticleViewHolder(NewTabPageRecyclerView parent, NewTabPageManager manager,
SnippetsBridge snippetsBridge) {
- super(R.layout.new_tab_page_snippets_card, parent);
+ super(R.layout.new_tab_page_snippets_card, parent, manager.getUiConfig());
mNewTabPageManager = manager;
mSnippetsBridge = snippetsBridge;
@@ -108,6 +110,20 @@ public void onViewDetachedFromWindow(View v) {
}
});
+ new DisplayStyleObserver.ViewAdapter(
+ itemView, manager.getUiConfig(), new DisplayStyleObserver() {
+ @Override
+ public void onDisplayStyleChanged(@UiConfig.DisplayStyle int newDisplayStyle) {
+ if (newDisplayStyle == UiConfig.DISPLAY_STYLE_NARROW) {
+ mHeadlineTextView.setMaxLines(4);
+ mArticleSnippetTextView.setVisibility(View.GONE);
+ } else {
+ mHeadlineTextView.setMaxLines(2);
+ mArticleSnippetTextView.setVisibility(View.VISIBLE);
+ }
+ }
+ });
+
mUseFaviconService =
!PARAMETER_DISABLED_VALUE.equals(VariationsAssociatedData.getVariationParamValue(
NewTabPage.FIELD_TRIAL_NAME, PARAMETER_FAVICON_SERVICE_NAME));

Powered by Google App Engine
This is Rietveld 408576698