chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java - Issue 2149333003: 📰 Adjust the card display depending on the screen width.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

Issue 2149333003: 📰 Adjust the card display depending on the screen width. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ZineTabletUI

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/UiConfig.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/MarginResizer.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusListItem.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

index 100bb308b63a19ec680997c499854388907f97c2..f6177b38b87eea13838486f2c97bf4f9c4376767 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

@@ -183,8 +183,7 @@ public NewTabPageViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {

}

if (viewType == NewTabPageListItem.VIEW_TYPE_HEADER) {

- return new SnippetHeaderViewHolder(

- SnippetHeaderListItem.createView(parent), mRecyclerView);

+ return new SnippetHeaderViewHolder(mRecyclerView, mNewTabPageManager.getUiConfig());

}

if (viewType == NewTabPageListItem.VIEW_TYPE_SNIPPET) {

@@ -196,7 +195,7 @@ public NewTabPageViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {

}

if (viewType == NewTabPageListItem.VIEW_TYPE_STATUS) {

- return new StatusListItem.ViewHolder(mRecyclerView);

+ return new StatusListItem.ViewHolder(mRecyclerView, mNewTabPageManager.getUiConfig());

}

return null;