Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3126)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2149333003: 📰 Adjust the card display depending on the screen width. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ZineTabletUI
Patch Set: address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
index 7f075a2fd6b92a5d07db0426c9411a8f1f30391e..b78ef0b6ef2b28e15cafab4c4e04b14a943341af 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
@@ -6,6 +6,7 @@
import android.annotation.SuppressLint;
import android.content.Context;
+import android.content.res.Configuration;
import android.content.res.Resources;
import android.graphics.Bitmap;
import android.graphics.BitmapFactory;
@@ -96,6 +97,7 @@
private OnSearchBoxScrollListener mSearchBoxScrollListener;
private NewTabPageManager mManager;
+ private UiConfig mUiConfig;
private MostVisitedDesign mMostVisitedDesign;
private MostVisitedItem[] mMostVisitedItems;
private boolean mFirstShow = true;
@@ -255,6 +257,7 @@ public NewTabPageView(Context context, AttributeSet attrs) {
public void initialize(NewTabPageManager manager, boolean searchProviderHasLogo,
SnippetsBridge snippetsBridge) {
mManager = manager;
+ mUiConfig = new UiConfig(this);
ViewStub stub = (ViewStub) findViewById(R.id.new_tab_page_layout_stub);
mUseCardsUi = snippetsBridge != null;
@@ -305,7 +308,8 @@ public void initialize(NewTabPageManager manager, boolean searchProviderHasLogo,
// Set up snippets
if (mUseCardsUi) {
- mNewTabPageAdapter = new NewTabPageAdapter(mManager, mNewTabPageLayout, snippetsBridge);
+ mNewTabPageAdapter =
+ new NewTabPageAdapter(mManager, mNewTabPageLayout, snippetsBridge, mUiConfig);
mRecyclerView.setAdapter(mNewTabPageAdapter);
// Set up swipe-to-dismiss
@@ -1102,6 +1106,18 @@ protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {
}
}
+ @Override
+ protected void onConfigurationChanged(Configuration newConfig) {
+ super.onConfigurationChanged(newConfig);
+
+ // When the viewport configuration changes, we want to update the display style so that the
+ // observers are aware of the new available space. Another moment to do this update could
+ // be through a OnLayoutChangeListener, but then we get notified of the change after the
+ // layout pass, which means that the new style will only be visible after layout happens
+ // again. We prefer updating here to avoid having to require that additional layout pass.
+ mUiConfig.updateDisplayStyle();
+ }
+
private int getVerticalScroll() {
if (mUseCardsUi) {
return mRecyclerView.computeVerticalScrollOffset();

Powered by Google App Engine
This is Rietveld 408576698