Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: chrome/android/java/res/layout/new_tab_page_snippets_card.xml

Issue 2149333003: 📰 Adjust the card display depending on the screen width. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ZineTabletUI
Patch Set: address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/res/layout/new_tab_page_snippets_header.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <RelativeLayout 6 <RelativeLayout
7 xmlns:android="http://schemas.android.com/apk/res/android" 7 xmlns:android="http://schemas.android.com/apk/res/android"
8 xmlns:chrome="http://schemas.android.com/apk/res-auto" 8 xmlns:chrome="http://schemas.android.com/apk/res-auto"
9 android:id="@+id/snippets_card_view" 9 android:id="@+id/snippets_card_view"
10 android:layout_width="match_parent" 10 android:layout_width="match_parent"
11 android:layout_height="wrap_content" 11 android:layout_height="wrap_content"
12 android:padding="@dimen/snippets_padding_and_peeking_card_height" 12 android:padding="@dimen/snippets_padding_and_peeking_card_height"
13 android:background="@drawable/ntp_card"> 13 android:background="@drawable/ntp_card">
14 14
15 <org.chromium.ui.widget.TextViewWithLeading 15 <org.chromium.ui.widget.TextViewWithLeading
16 android:id="@+id/article_headline" 16 android:id="@+id/article_headline"
17 android:layout_width="match_parent" 17 android:layout_width="match_parent"
18 android:layout_height="wrap_content" 18 android:layout_height="wrap_content"
19 android:layout_alignParentStart="true" 19 android:layout_alignParentStart="true"
20 android:layout_toStartOf="@+id/article_thumbnail" 20 android:layout_toStartOf="@+id/article_thumbnail"
21 android:lines="2"
22 android:ellipsize="end" 21 android:ellipsize="end"
23 android:textSize="16sp" 22 android:textSize="16sp"
24 android:textColor="@color/snippets_headline_text_color" 23 android:textColor="@color/snippets_headline_text_color"
25 chrome:leading="24dp" /> 24 chrome:leading="24dp" />
26 25
27 <org.chromium.ui.widget.TextViewWithLeading 26 <org.chromium.ui.widget.TextViewWithLeading
28 android:id="@+id/article_snippet" 27 android:id="@+id/article_snippet"
29 android:layout_width="match_parent" 28 android:layout_width="match_parent"
30 android:layout_height="wrap_content" 29 android:layout_height="wrap_content"
31 android:layout_alignParentStart="true" 30 android:layout_alignParentStart="true"
32 android:layout_below="@+id/article_headline" 31 android:layout_below="@+id/article_headline"
33 android:layout_toStartOf="@+id/article_thumbnail" 32 android:layout_toStartOf="@+id/article_thumbnail"
34 android:layout_marginTop="8dp" 33 android:layout_marginTop="8dp"
35 android:lines="2" 34 android:maxLines="2"
36 android:ellipsize="end" 35 android:ellipsize="end"
37 android:textSize="14sp" 36 android:textSize="14sp"
38 android:textColor="@color/snippets_text_color" 37 android:textColor="@color/snippets_text_color"
39 chrome:leading="20dp" /> 38 chrome:leading="20dp" />
40 39
41 <TextView 40 <TextView
42 android:id="@+id/article_publisher" 41 android:id="@+id/article_publisher"
43 android:layout_width="match_parent" 42 android:layout_width="match_parent"
44 android:layout_height="wrap_content" 43 android:layout_height="wrap_content"
45 android:layout_marginTop="16dp" 44 android:layout_marginTop="16dp"
(...skipping 11 matching lines...) Expand all
57 android:background="@color/snippets_thumnail_placeholder_bg" 56 android:background="@color/snippets_thumnail_placeholder_bg"
58 android:layout_width="@dimen/snippets_thumbnail_size" 57 android:layout_width="@dimen/snippets_thumbnail_size"
59 android:layout_height="@dimen/snippets_thumbnail_size" 58 android:layout_height="@dimen/snippets_thumbnail_size"
60 android:layout_alignParentTop="true" 59 android:layout_alignParentTop="true"
61 android:layout_alignParentEnd="true" 60 android:layout_alignParentEnd="true"
62 android:layout_marginStart="16dp" 61 android:layout_marginStart="16dp"
63 android:scaleType="centerCrop" 62 android:scaleType="centerCrop"
64 android:contentDescription="@null" 63 android:contentDescription="@null"
65 android:src="@null" /> 64 android:src="@null" />
66 </RelativeLayout> 65 </RelativeLayout>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/res/layout/new_tab_page_snippets_header.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698