Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2149303003: Revert "Make toLocaleString on arrays always call toLocaleString on its elements." (Closed)

Created:
4 years, 5 months ago by neis
Modified:
4 years, 5 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Make toLocaleString on arrays always call toLocaleString on its elements." This reverts commit 457c02573cc25ce548a88457cc6e23ef73a637a1 because it caused a regression in SunSpider/string-fasta and possibly AreWeFastYet/Life. Need to implement this in a smarter way. TBR=littledan@chromium.org BUG=chromium:627729, v8:5113 Committed: https://crrev.com/f47e7224034261bf62167a36959d5e287c4fc136 Cr-Commit-Position: refs/heads/master@{#37793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -41 lines) Patch
M src/js/array.js View 2 chunks +23 lines, -5 lines 0 comments Download
M test/mjsunit/array-tostring.js View 2 chunks +1 line, -23 lines 0 comments Download
M test/mjsunit/es6/typedarray-tostring.js View 1 chunk +0 lines, -13 lines 0 comments Download
M test/test262/test262.status View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149303003/1
4 years, 5 months ago (2016-07-15 11:01:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 11:27:44 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 11:28:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f47e7224034261bf62167a36959d5e287c4fc136
Cr-Commit-Position: refs/heads/master@{#37793}

Powered by Google App Engine
This is Rietveld 408576698