service worker: Tweak some documentation.

service worker: Tweak some documentation.

Things I wanted clarified while investigating https://crbug.com/625042

BUG=625042
Committed: https://crrev.com/16619c07cc73a2e46063a18e073e8b9dc696f4eb
Cr-Commit-Position: refs/heads/master@{#407013}

[falken, 2016-07-15 05:51:37]

falken@chromium.org changed reviewers:
+ nhiroki@chromium.org

[falken, 2016-07-15 05:51:38]

wdyt of these

[falken, 2016-07-15 05:52:15]

The CQ bit was checked by falken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 05:52:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 07:16:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 07:16:02]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2016-07-19 03:37:53]

lgtm with minor comments.

https://codereview.chromium.org/2149273003/diff/1/content/browser/service_wor...
File content/browser/service_worker/embedded_worker_registry.cc (right):

https://codereview.chromium.org/2149273003/diff/1/content/browser/service_wor...
content/browser/service_worker/embedded_worker_registry.cc:259: #ifndef NDEBUG
"#if DCHECK_IS_ON()" would be better for DCHECK_ALWAYS_ON

https://codereview.chromium.org/2149273003/diff/1/content/browser/service_wor...
content/browser/service_worker/embedded_worker_registry.cc:263:
DCHECK_EQ(found->second->process_id(), process_id);
Optional: I'd prefer not to have macros in a production code as much as possible
in terms of readability. With following code, we could avoid them:

DCHECK(GetWorker(embedded_worker_id));
DCHECK_EQ(GetWorker(embedded_worker_id)->process_id(), process_id);

https://codereview.chromium.org/2149273003/diff/1/content/browser/service_wor...
content/browser/service_worker/embedded_worker_registry.cc:266:
worker_process_map_[process_id].count(embedded_worker_id) == 0);
Optional: "!ContainsKey(worker_process_map_[process_id], embedded_worker_id)"
would be consistent with the former expression.

[falken, 2016-07-22 01:34:47]

Thank you.

https://codereview.chromium.org/2149273003/diff/1/content/browser/service_wor...
File content/browser/service_worker/embedded_worker_registry.cc (right):

https://codereview.chromium.org/2149273003/diff/1/content/browser/service_wor...
content/browser/service_worker/embedded_worker_registry.cc:259: #ifndef NDEBUG
On 2016/07/19 03:37:53, nhiroki (slow) wrote:
> "#if DCHECK_IS_ON()" would be better for DCHECK_ALWAYS_ON

Acknowledged.

https://codereview.chromium.org/2149273003/diff/1/content/browser/service_wor...
content/browser/service_worker/embedded_worker_registry.cc:263:
DCHECK_EQ(found->second->process_id(), process_id);
On 2016/07/19 03:37:53, nhiroki (slow) wrote:
> Optional: I'd prefer not to have macros in a production code as much as
possible
> in terms of readability. With following code, we could avoid them:
> 
> DCHECK(GetWorker(embedded_worker_id));
> DCHECK_EQ(GetWorker(embedded_worker_id)->process_id(), process_id);

Much better, done.

https://codereview.chromium.org/2149273003/diff/1/content/browser/service_wor...
content/browser/service_worker/embedded_worker_registry.cc:266:
worker_process_map_[process_id].count(embedded_worker_id) == 0);
On 2016/07/19 03:37:53, nhiroki (slow) wrote:
> Optional: "!ContainsKey(worker_process_map_[process_id], embedded_worker_id)"
> would be consistent with the former expression.

Huh yea. Not sure why I used count in the first place.

[falken, 2016-07-22 01:34:51]

The CQ bit was checked by falken@chromium.org

[falken, 2016-07-22 01:34:52]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/2149273003/#ps40001
(title: "comments")

[commit-bot: I haz the power, 2016-07-22 01:35:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 03:18:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-22 03:19:54]

Description was changed from

==========
service worker: Tweak some documentation.

Things I wanted clarified while investigating https://crbug.com/625042

BUG=625042
==========

to

==========
service worker: Tweak some documentation.

Things I wanted clarified while investigating https://crbug.com/625042

BUG=625042

Committed: https://crrev.com/16619c07cc73a2e46063a18e073e8b9dc696f4eb
Cr-Commit-Position: refs/heads/master@{#407013}
==========

[commit-bot: I haz the power, 2016-07-22 03:19:55]

Patchset 3 (id:??) landed as
https://crrev.com/16619c07cc73a2e46063a18e073e8b9dc696f4eb
Cr-Commit-Position: refs/heads/master@{#407013}