Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2149253005: Revert of Rotate emoji with FreeType. (Closed)

Created:
4 years, 5 months ago by bungeman-skia
Modified:
4 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Rotate emoji with FreeType. (patchset #5 id:80001 of https://codereview.chromium.org/2139703002/ ) Reason for revert: Causing roll to fail on telemetry_perf_unittests (bencharks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:search:taobao (and baidu)) and browser_tests (FindInPageControllerTest.FindInPageSpecialURLS). This is due to triggering the assert in copyFTBitmap SkASSERT(dstMask.fBounds.width() == static_cast<int>(srcFTBitmap.width)); when called from inside the block guarded by if (bitmapTransform.isIdentity()) Original issue's description: > Rotate bitmap strikes with FreeType. > > BUG=skia:3490 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2139703002 > > Committed: https://skia.googlesource.com/skia/+/31e0c1379e6d0ce48196183e295b929af51fa74e TBR=mtklein@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3490 Committed: https://skia.googlesource.com/skia/+/280d537e2893ee036c5e58e23438b12d30d634ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -135 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 15 chunks +100 lines, -118 lines 0 comments Download
M src/ports/SkFontHost_FreeType_common.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ports/SkFontHost_FreeType_common.cpp View 5 chunks +8 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bungeman-skia
Created Revert of Rotate emoji with FreeType.
4 years, 5 months ago (2016-07-16 01:49:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149253005/1
4 years, 5 months ago (2016-07-16 01:49:37 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-16 01:49:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/280d537e2893ee036c5e58e23438b12d30d634ee

Powered by Google App Engine
This is Rietveld 408576698