Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: components/policy/core/browser/proxy_policy_handler.cc

Issue 2149253003: Switch various ValueTypeToString()s to base::Value::GetTypeName(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@value
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/browser/proxy_policy_handler.cc
diff --git a/components/policy/core/browser/proxy_policy_handler.cc b/components/policy/core/browser/proxy_policy_handler.cc
index 8bd587fcf12f8dfd87f4255ad2fc1f7cf99d7448..a53726d44c35ae63313f69ae719b1fdaaa4e9246 100644
--- a/components/policy/core/browser/proxy_policy_handler.cc
+++ b/components/policy/core/browser/proxy_policy_handler.cc
@@ -255,10 +255,9 @@ bool ProxyPolicyHandler::CheckProxyModeAndServerMode(const PolicyMap& policies,
key::kProxyMode);
}
if (!mode->GetAsString(mode_value)) {
- errors->AddError(key::kProxySettings,
- key::kProxyMode,
+ errors->AddError(key::kProxySettings, key::kProxyMode,
IDS_POLICY_TYPE_ERROR,
- ValueTypeToString(base::Value::TYPE_BOOLEAN));
+ base::Value::GetTypeName(base::Value::TYPE_BOOLEAN));
return false;
}
@@ -275,7 +274,8 @@ bool ProxyPolicyHandler::CheckProxyModeAndServerMode(const PolicyMap& policies,
key::kProxyPacUrl,
IDS_POLICY_NOT_SPECIFIED_ERROR);
return false;
- } else if (mode == ProxyPrefs::MODE_FIXED_SERVERS && !server) {
+ }
+ if (mode == ProxyPrefs::MODE_FIXED_SERVERS && !server) {
errors->AddError(key::kProxySettings,
key::kProxyServer,
IDS_POLICY_NOT_SPECIFIED_ERROR);
@@ -284,10 +284,9 @@ bool ProxyPolicyHandler::CheckProxyModeAndServerMode(const PolicyMap& policies,
} else if (server_mode) {
int server_mode_value;
if (!server_mode->GetAsInteger(&server_mode_value)) {
- errors->AddError(key::kProxySettings,
- key::kProxyServerMode,
+ errors->AddError(key::kProxySettings, key::kProxyServerMode,
IDS_POLICY_TYPE_ERROR,
- ValueTypeToString(base::Value::TYPE_INTEGER));
+ base::Value::GetTypeName(base::Value::TYPE_INTEGER));
return false;
}
@@ -319,10 +318,8 @@ bool ProxyPolicyHandler::CheckProxyModeAndServerMode(const PolicyMap& policies,
message_id);
return false;
}
- if (pac_url)
- *mode_value = ProxyPrefs::kPacScriptProxyModeName;
- else
- *mode_value = ProxyPrefs::kFixedServersProxyModeName;
+ *mode_value = pac_url ? ProxyPrefs::kPacScriptProxyModeName
+ : ProxyPrefs::kFixedServersProxyModeName;
break;
case PROXY_USE_SYSTEM_PROXY_SERVER_MODE:
*mode_value = ProxyPrefs::kSystemProxyModeName;

Powered by Google App Engine
This is Rietveld 408576698