Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: chrome/browser/policy/javascript_policy_handler.cc

Issue 2149253003: Switch various ValueTypeToString()s to base::Value::GetTypeName(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@value
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/javascript_policy_handler.cc
diff --git a/chrome/browser/policy/javascript_policy_handler.cc b/chrome/browser/policy/javascript_policy_handler.cc
index cc0b35c31f3e066f5096189b0e9c8b3d14238080..bc84ac26d1cf1fe9a5d35227ffbc030c15c673a1 100644
--- a/chrome/browser/policy/javascript_policy_handler.cc
+++ b/chrome/browser/policy/javascript_policy_handler.cc
@@ -28,15 +28,13 @@ bool JavascriptPolicyHandler::CheckPolicySettings(const PolicyMap& policies,
if (javascript_enabled &&
!javascript_enabled->IsType(base::Value::TYPE_BOOLEAN)) {
- errors->AddError(key::kJavascriptEnabled,
- IDS_POLICY_TYPE_ERROR,
- ValueTypeToString(base::Value::TYPE_BOOLEAN));
+ errors->AddError(key::kJavascriptEnabled, IDS_POLICY_TYPE_ERROR,
+ base::Value::GetTypeName(base::Value::TYPE_BOOLEAN));
}
if (default_setting && !default_setting->IsType(base::Value::TYPE_INTEGER)) {
- errors->AddError(key::kDefaultJavaScriptSetting,
- IDS_POLICY_TYPE_ERROR,
- ValueTypeToString(base::Value::TYPE_INTEGER));
+ errors->AddError(key::kDefaultJavaScriptSetting, IDS_POLICY_TYPE_ERROR,
+ base::Value::GetTypeName(base::Value::TYPE_INTEGER));
}
if (javascript_enabled && default_setting) {
« no previous file with comments | « chrome/browser/extensions/policy_handlers.cc ('k') | chrome/browser/policy/network_prediction_policy_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698