tools/json_schema_compiler/util_cc_helper.py - Issue 2149253003: Switch various ValueTypeToString()s to base::Value::GetTypeName().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/util_cc_helper.py

Issue 2149253003: Switch various ValueTypeToString()s to base::Value::GetTypeName(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@value

Patch Set: fix tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/json_schema_compiler/util_cc_helper.py

diff --git a/tools/json_schema_compiler/util_cc_helper.py b/tools/json_schema_compiler/util_cc_helper.py

index e81c4e359435fada0abc6e481300a8ebc5fb7399..5f5ab0fd136a10e167e20fd08bd768dba4127299 100644

--- a/tools/json_schema_compiler/util_cc_helper.py

+++ b/tools/json_schema_compiler/util_cc_helper.py

@@ -39,4 +39,4 @@ class UtilCCHelper(object):

call = '.GetType()'

if is_ptr:

call = '->GetType()'

- return 'json_schema_compiler::util::ValueTypeToString(%s%s)' % (value, call)

+ return 'std::string(base::Value::GetTypeName(%s%s))' % (value, call)

« tools/json_schema_compiler/util.cc ('K') | « tools/json_schema_compiler/util.cc ('k') | no next file » | no next file with comments »