Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: tools/json_schema_compiler/util.h

Issue 2149253003: Switch various ValueTypeToString()s to base::Value::GetTypeName(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@value
Patch Set: fix tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/util.h
diff --git a/tools/json_schema_compiler/util.h b/tools/json_schema_compiler/util.h
index 8b852739f6a1078b5fca50e38612fdd49e4bf6b1..d7862cea4f63a6682cbe25aebc8bbe0a67eae08e 100644
--- a/tools/json_schema_compiler/util.h
+++ b/tools/json_schema_compiler/util.h
@@ -207,13 +207,9 @@ std::unique_ptr<base::Value> CreateValueFromArray(const std::vector<T>& from) {
template <class T>
std::unique_ptr<base::Value> CreateValueFromOptionalArray(
const std::unique_ptr<std::vector<T>>& from) {
- if (from)
- return CreateValueFromArray(*from);
- return nullptr;
+ return from ? CreateValueFromArray(*from) : nullptr;
}
-std::string ValueTypeToString(base::Value::Type type);
-
} // namespace util
} // namespace json_schema_compiler

Powered by Google App Engine
This is Rietveld 408576698