components/policy/core/browser/configuration_policy_handler.h - Issue 2149253003: Switch various ValueTypeToString()s to base::Value::GetTypeName().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/browser/configuration_policy_handler.h

Issue 2149253003: Switch various ValueTypeToString()s to base::Value::GetTypeName(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@value

Patch Set: fix tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/incognito_mode_policy_handler.cc ('K') | « chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc ('k') | components/policy/core/browser/configuration_policy_handler.cc » ('j') | tools/json_schema_compiler/util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/browser/configuration_policy_handler.h

diff --git a/components/policy/core/browser/configuration_policy_handler.h b/components/policy/core/browser/configuration_policy_handler.h

index 2853ce8fca80c6e75ae8a0ad9437fbb73463e427..a390b79c7992ed1e914a8778bcd0f3afc247a9d6 100644

--- a/components/policy/core/browser/configuration_policy_handler.h

+++ b/components/policy/core/browser/configuration_policy_handler.h

@@ -36,9 +36,6 @@ struct POLICY_EXPORT PolicyToPreferenceMapEntry {

// their corresponding preferences, and to check whether the policies are valid.

class POLICY_EXPORT ConfigurationPolicyHandler {

public:

- // TODO(thestig): Replace with base::Value::GetTypeName().

- static std::string ValueTypeToString(base::Value::Type type);

ConfigurationPolicyHandler();

virtual ~ConfigurationPolicyHandler();