Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2149243003: [Editing][DOM][CodeHealth] Remove unused enum Node::UserSelectAllTreatment. (Closed)

Created:
4 years, 5 months ago by yoichio
Modified:
4 years, 5 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, kinuko+watch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Editing][DOM][CodeHealth] Remove unused enum Node::UserSelectAllTreatment. No one uses the enum because I deleted it: https://codereview.chromium.org/2120913002. TEST=No change in behavior. Committed: https://crrev.com/28bafd337a13f72d774e2ced9ac2146278adf99b Cr-Commit-Position: refs/heads/master@{#405734}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M third_party/WebKit/Source/core/dom/Node.h View 3 chunks +5 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertNodeBeforeCommand.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/RemoveNodeCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
yoichio
4 years, 5 months ago (2016-07-15 07:24:43 UTC) #5
tkent
lgtm
4 years, 5 months ago (2016-07-15 07:48:58 UTC) #6
yosin_UTC9
lgtm Thanks for cleanup!
4 years, 5 months ago (2016-07-15 08:32:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149243003/1
4 years, 5 months ago (2016-07-15 09:41:34 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 09:46:42 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 09:46:44 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 09:47:55 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28bafd337a13f72d774e2ced9ac2146278adf99b
Cr-Commit-Position: refs/heads/master@{#405734}

Powered by Google App Engine
This is Rietveld 408576698